Skip to content

Commit de0ec23

Browse files
committed
beacon: fix AttributeError by using aiohttp.ClientTimeout throughout
Traceback (most recent call last): File "/home/lukas/Documents/git/web3.py/test-script.py", line 33, in <module> loop.run_until_complete(main()) File "/usr/lib64/python3.12/asyncio/base_events.py", line 687, in run_until_complete return future.result() ^^^^^^^^^^^^^^^ File "/home/lukas/Documents/git/web3.py/test-script.py", line 22, in main validator = await beacon.get_validator(str(validator_id)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/lukas/Documents/git/web3.py/web3/beacon/async_beacon.py", line 114, in get_validator return await self._async_make_get_request( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/lukas/Documents/git/web3.py/web3/beacon/async_beacon.py", line 77, in _async_make_get_request return await self._request_session_manager.async_json_make_get_request( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/lukas/Documents/git/web3.py/web3/_utils/http_session_manager.py", line 248, in async_json_make_get_request response = await self.async_get_response_from_get_request( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/lukas/Documents/git/web3.py/web3/_utils/http_session_manager.py", line 239, in async_get_response_from_get_request session = await self.async_cache_and_return_session( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/lukas/Documents/git/web3.py/web3/_utils/http_session_manager.py", line 228, in async_cache_and_return_session request_timeout.total or DEFAULT_HTTP_TIMEOUT + 0.1, ^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'float' object has no attribute 'total' Signed-off-by: Lukas Rusak <[email protected]>
1 parent abeed70 commit de0ec23

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

web3/beacon/async_beacon.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
Optional,
66
)
77

8+
from aiohttp import (
9+
ClientTimeout,
10+
)
811
from eth_typing import (
912
URI,
1013
HexStr,
@@ -64,7 +67,7 @@ def __init__(
6467
request_timeout: float = 10.0,
6568
) -> None:
6669
self.base_url = base_url
67-
self.request_timeout = request_timeout
70+
self.request_timeout = ClientTimeout(request_timeout)
6871
self._request_session_manager = HTTPSessionManager()
6972

7073
async def _async_make_get_request(

web3/beacon/beacon.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
Optional,
66
)
77

8+
from aiohttp import (
9+
ClientTimeout,
10+
)
811
from eth_typing import (
912
URI,
1013
HexStr,
@@ -62,7 +65,7 @@ def __init__(
6265
request_timeout: float = 10.0,
6366
) -> None:
6467
self.base_url = base_url
65-
self.request_timeout = request_timeout
68+
self.request_timeout = ClientTimeout(request_timeout)
6669
self._request_session_manager = HTTPSessionManager()
6770

6871
def _make_get_request(

0 commit comments

Comments
 (0)