Skip to content

Update to TypeScript 4.1 #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 21, 2020
Merged

Conversation

josephaxisa
Copy link
Contributor

No description provided.

@josephaxisa josephaxisa requested a review from jkaster December 21, 2020 18:38
@github-actions
Copy link
Contributor

Test Results

     14 files       14 suites   1m 22s ⏱️
   139 tests    139 ✔️ 0 💤 0 ❌
1 426 runs  1 426 ✔️ 0 💤 0 ❌

Results for commit 1604c6e.

Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Great to finally get TS updated

Comment on lines +405 to +406
const swaggerFile = `${config.rootPath}spec/Looker.4.0.json`
const apiFile = `${config.rootPath}spec/Looker.4.0.oas.json`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testUtils now has a rootFile() function we can use to fix this up in a future PR

@jkaster jkaster merged commit c46d43e into jax/update-looker-components Dec 21, 2020
@jkaster jkaster deleted the jax/update-typescript branch December 21, 2020 19:51
@josephaxisa josephaxisa restored the jax/update-typescript branch December 22, 2020 10:02
@josephaxisa josephaxisa deleted the jax/update-typescript branch December 22, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants