Skip to content

Fix: fixed bug in go example #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025
Merged

Fix: fixed bug in go example #1595

merged 2 commits into from
Jul 18, 2025

Conversation

drstrangelooker
Copy link
Collaborator

Fix minor bug

@drstrangelooker drstrangelooker requested a review from a team as a code owner July 18, 2025 19:40
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @drstrangelooker, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor bug within the Go example code. The change specifically fixes a fmt.Printf call to correctly pass the required argument for its format specifier, ensuring accurate logging and preventing potential runtime issues.

Highlights

  • Bug Fix: Corrected a fmt.Printf statement in go/example/main.go that was missing an argument (len(users)) for the %d format specifier. This ensures the print statement functions as intended and avoids potential runtime errors or incorrect output.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

github-actions bot commented Jul 18, 2025

Go Tests

  6 files  +  4    6 suites  +6   2m 13s ⏱️ + 2m 13s
 50 tests + 50   50 ✅ + 50  0 💤 ±0  0 ❌ ±0 
120 runs  +120  120 ✅ +120  0 💤 ±0  0 ❌ ±0 

Results for commit 459e979. ± Comparison against base commit 19ce626.

♻️ This comment has been updated with latest results.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug in an example Go program where a Printf call was missing an argument for its format string. The change correctly adds the missing argument. My review includes a suggestion to improve the logging by writing the diagnostic message to stderr instead of stdout, following common Go practices.

@@ -48,7 +48,7 @@ func printAboutMe(sdk *v4.LookerSDK) {
fmt.Printf("Error getting myself %v\n", err)
}
if len(users) != 1 {
fmt.Printf("Found %d users with my email expected 1\n")
fmt.Printf("Found %d users with my email expected 1\n", len(users))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The fix to include len(users) is correct, thanks for catching that.

To improve this, I suggest writing this warning message to stderr instead of stdout, which is a common practice for diagnostic messages in Go. This separates them from the program's primary output.

Also, please note that if sdk.SearchUsers returns an error, this line will still be executed. It would be more robust to check len(users) only when the API call is successful. While I can't suggest a change for the surrounding logic due to PR constraints, here's a suggestion for the current line:

Suggested change
fmt.Printf("Found %d users with my email expected 1\n", len(users))
fmt.Fprintf(os.Stderr, "Warning: Found %d users with my email, expected 1\n", len(users))

@drstrangelooker drstrangelooker merged commit 6e45409 into main Jul 18, 2025
20 checks passed
@drstrangelooker drstrangelooker deleted the fix-go-example branch July 18, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant