-
Notifications
You must be signed in to change notification settings - Fork 199
Fix: fixed bug in go example #1595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @drstrangelooker, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a minor bug within the Go example code. The change specifically fixes a fmt.Printf
call to correctly pass the required argument for its format specifier, ensuring accurate logging and preventing potential runtime issues.
Highlights
- Bug Fix: Corrected a
fmt.Printf
statement ingo/example/main.go
that was missing an argument (len(users)
) for the%d
format specifier. This ensures the print statement functions as intended and avoids potential runtime errors or incorrect output.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a bug in an example Go program where a Printf
call was missing an argument for its format string. The change correctly adds the missing argument. My review includes a suggestion to improve the logging by writing the diagnostic message to stderr
instead of stdout
, following common Go practices.
@@ -48,7 +48,7 @@ func printAboutMe(sdk *v4.LookerSDK) { | |||
fmt.Printf("Error getting myself %v\n", err) | |||
} | |||
if len(users) != 1 { | |||
fmt.Printf("Found %d users with my email expected 1\n") | |||
fmt.Printf("Found %d users with my email expected 1\n", len(users)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix to include len(users)
is correct, thanks for catching that.
To improve this, I suggest writing this warning message to stderr
instead of stdout
, which is a common practice for diagnostic messages in Go. This separates them from the program's primary output.
Also, please note that if sdk.SearchUsers
returns an error, this line will still be executed. It would be more robust to check len(users)
only when the API call is successful. While I can't suggest a change for the surrounding logic due to PR constraints, here's a suggestion for the current line:
fmt.Printf("Found %d users with my email expected 1\n", len(users)) | |
fmt.Fprintf(os.Stderr, "Warning: Found %d users with my email, expected 1\n", len(users)) |
Fix minor bug