Skip to content

Commit de55787

Browse files
authored
Merge branch 'main' into jk/show_requesturl
2 parents 7f48a16 + f1fe4f5 commit de55787

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

packages/hackathon/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ application: hackathon {
3838
"https://*.slack.com/*",
3939
"https://*.github.com/*",
4040
"https://*.youtube.com/*",
41+
"https://*.youtu.be/*",
4142
"https://*.vimeo.com/*"
4243
]
4344
use_form_submit: yes

packages/hackathon/src/models/sheetUtils.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
*/
2626
import type { SheetValues } from '@looker/wholly-sheet'
2727
import type { DataTableColumn, DataTableColumns } from '@looker/components'
28-
import { Icon } from '@looker/components'
28+
import { Span, Icon } from '@looker/components'
2929
import { Done } from '@styled-icons/material/Done'
3030
import React from 'react'
3131

@@ -86,10 +86,10 @@ export const sheetHeader = (header: string[], row: any) => {
8686
* @param value to convert to displayable actionitem
8787
*/
8888
export const sheetCell = (value: any) => {
89-
if (typeof value === 'undefined') return ''
89+
if (typeof value === 'undefined') return <Span></Span>
9090

9191
if (typeof value === 'boolean') {
92-
return value ? <Icon size="small" icon={<Done />} /> : ''
92+
return value ? <Icon size="small" icon={<Done />} /> : <Span></Span>
9393
}
9494

9595
if (value instanceof Set) {
@@ -98,10 +98,10 @@ export const sheetCell = (value: any) => {
9898
for (const v of value.values()) {
9999
values.push(v.toString())
100100
}
101-
return values.join(', ')
101+
return <Span>{values.join(', ')}</Span>
102102
}
103103
if (value instanceof Date) {
104-
return value.toDateString()
104+
return <Span>{value.toDateString()}</Span>
105105
}
106-
return value.toString()
106+
return <Span>{value.toString()}</Span>
107107
}

0 commit comments

Comments
 (0)