Fixes dart lint issues.

Author: bryans99

dart/looker_sdk/README.md

@@ -55,9 +55,13 @@ Run `yarn test` from `{reporoot}/dart/looker_sdk` to run all tests.
 
 Run `yarn format` from `{reporoot}/dart/looker_sdk` to format the `dart` files correctly. This should be run if you change any of the run time library `dart` files. The repo CI will run the linter and will fail if the files have not been correctly formatted.
 
-### Run format
+### Run format-check
+
+Run `yarn format-check` from `{reporoot}/dart/looker_sdk` to check the formatting of the `dart` files.
+
+### Run analyze
 
-Run `yarn format` from `{reporoot}/dart/looker_sdk` to lint the `dart` files.
+Run `yarn format-analyze` from `{reporoot}/dart/looker_sdk` to lint the `dart` files.
 
 ## TODOs
 

dart/looker_sdk/analysis_options.yaml

@@ -1,3 +1,3 @@
-include: package:pedantic/analysis_options.yaml
+include: package:lints/recommended.yaml
 
 analyzer:

dart/looker_sdk/example/main.dart

@@ -21,16 +21,18 @@ Future<LookerSDK> createSdk() async {
 
 Future<void> runLooks(LookerSDK sdk) async {
   try {
-    var looks = await sdk.ok(sdk.all_looks());
+    var looks = await sdk.ok(sdk.allLooks());
     if (looks.isNotEmpty) {
-      looks.forEach((look) => print(look.title));
-      var look = await sdk.ok(sdk.run_look(looks[looks.length - 1].id, 'png'));
+      for (var look in looks) {
+        print(look.title);
+      }
+      var look = await sdk.ok(sdk.runLook(looks[looks.length - 1].id, 'png'));
       var dir = Directory('./temp');
       if (!dir.existsSync()) {
         dir.createSync();
       }
       File('./temp/look.png').writeAsBytesSync(look as Uint8List);
-      look = await sdk.ok(sdk.run_look(looks[looks.length - 1].id, 'csv'));
+      look = await sdk.ok(sdk.runLook(looks[looks.length - 1].id, 'csv'));
       File('./temp/look.csv').writeAsStringSync(look as String);
     }
   } catch (error, stacktrace) {
@@ -41,8 +43,10 @@ Future<void> runLooks(LookerSDK sdk) async {
 
 Future<void> runDashboardApis(LookerSDK sdk) async {
   try {
-    var dashboards = await sdk.ok(sdk.all_dashboards());
-    dashboards.forEach((dashboard) => print(dashboard.title));
+    var dashboards = await sdk.ok(sdk.allDashboards());
+    for (var dashboard in dashboards) {
+      print(dashboard.title);
+    }
     var dashboard = await sdk.ok(sdk.dashboard(dashboards[0].id));
     print(dashboard.toJson());
   } catch (error, stacktrace) {
@@ -53,8 +57,10 @@ Future<void> runDashboardApis(LookerSDK sdk) async {
 
 Future<void> runConnectionApis(LookerSDK sdk) async {
   try {
-    var connections = await sdk.ok(sdk.all_connections());
-    connections.forEach((connection) => print(connection.name));
+    var connections = await sdk.ok(sdk.allConnections());
+    for (var connection in connections) {
+      print(connection.name);
+    }
     var connection = await sdk
         .ok(sdk.connection(connections[0].name, fields: 'name,host,port'));
     print(
@@ -72,22 +78,24 @@ Future<void> runConnectionApis(LookerSDK sdk) async {
       newConnection.password = 'look_your_data';
       newConnection.database = 'demo_db2';
       newConnection.tmpDbName = 'looker_demo_scratch';
-      connection = await sdk.ok(sdk.create_connection(newConnection));
+      connection = await sdk.ok(sdk.createConnection(newConnection));
       print('created ${connection.name}');
     }
     var updateConnection = WriteDBConnection();
     updateConnection.username = 'looker_demo';
     connection =
-        await sdk.ok(sdk.update_connection('TestConnection', updateConnection));
+        await sdk.ok(sdk.updateConnection('TestConnection', updateConnection));
     print('Connection updated: username=${connection.username}');
     var testResults = await sdk.ok(
-        sdk.test_connection('TestConnection', tests: DelimList(['connect'])));
+        sdk.testConnection('TestConnection', tests: DelimList(['connect'])));
     if (testResults.isEmpty) {
       print('No connection tests run');
     } else {
-      testResults.forEach((i) => print('test result: ${i.name}=${i.message}'));
+      for (var i in testResults) {
+        print('test result: ${i.name}=${i.message}');
+      }
     }
-    var deleteResult = await sdk.ok(sdk.delete_connection('TestConnection'));
+    var deleteResult = await sdk.ok(sdk.deleteConnection('TestConnection'));
     print('Delete result $deleteResult');
   } catch (error, stacktrace) {
     print(error);

dart/looker_sdk/lib/src/rtl/api_methods.dart

@@ -48,8 +48,7 @@ class APIMethods {
       T Function(dynamic responseData, String contentType) responseHandler,
       String path,
       [dynamic queryParams,
-      dynamic body,
-      T responseInstance]) async {
+      dynamic body]) async {
     var headers = await _getHeaders();
     return _authSession.transport.request(responseHandler, HttpMethod.delete,
         '${_authSession.apiPath}$path', queryParams, body, headers);
@@ -59,8 +58,7 @@ class APIMethods {
       T Function(dynamic responseData, String contentType) responseHandler,
       String path,
       [dynamic queryParams,
-      dynamic body,
-      T responseInstance]) async {
+      dynamic body]) async {
     var headers = await _getHeaders();
     var requestBody = body == null ? null : jsonEncode(body);
     return _authSession.transport.request(responseHandler, HttpMethod.post,
@@ -71,8 +69,7 @@ class APIMethods {
       T Function(dynamic responseData, String contentType) responseHandler,
       String path,
       [dynamic queryParams,
-      dynamic body,
-      T responseInstance]) async {
+      dynamic body]) async {
     var headers = await _getHeaders();
     return _authSession.transport.request(responseHandler, HttpMethod.put,
         '${_authSession.apiPath}$path', queryParams, body, headers);
@@ -82,10 +79,9 @@ class APIMethods {
       T Function(dynamic responseData, String contentType) responseHandler,
       String path,
       [dynamic queryParams,
-      dynamic body,
-      T responseInstance]) async {
+      dynamic body]) async {
     var headers = await _getHeaders();
-    var requestBody;
+    Object requestBody;
     if (body != null) {
       body.removeWhere((key, value) => value == null);
       requestBody = jsonEncode(body);

dart/looker_sdk/lib/src/rtl/auth_session.dart

@@ -58,7 +58,10 @@ class AuthSession {
   }
 
   Future<bool> logout() async {
-    Function jsonHandler = (Map json) => json;
+    dynamic jsonHandler(dynamic json, String contentType) {
+      return json;
+    }
+
     try {
       await ok(transport.request(
           jsonHandler,

dart/looker_sdk/lib/src/rtl/transport.dart

@@ -128,8 +128,8 @@ class Transport {
   SDKResponse<T> handleResponse<T>(http.Response response,
       T Function(dynamic response, String contentType) responseHandler) {
     var ok = response.statusCode >= 200 && response.statusCode <= 299;
-    var result;
-    var responseBody;
+    Object result;
+    Object responseBody;
     var contentType = response.headers['content-type'] ?? '';
     if (contentType.startsWith('application/json')) {
       responseBody = jsonDecode(response.body);