Skip to content

Commit 108aeef

Browse files
committed
fix readme
1 parent 6d68297 commit 108aeef

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

dart/looker_sdk/README.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ Relies on `yarn` and `dart` being installed. This was developed with `dart` vers
3232

3333
### Generate
3434

35-
Run `yarn sdk Gen` from the `{reporoot}`. Note that the SDK generator needs to be built `yarn build`. If changing the generator run 'yarn watch` in a separate window. This command generates two files:
35+
Run `yarn sdk Gen` from the `{reporoot}`. Note that the SDK generator needs to be built using `yarn build`. If changing the generator run 'yarn watch` in a separate window. This command generates two files:
3636

3737
1. `{reporoot}/dart/looker_sdk/lib/src/sdk/methods.dart`
3838
2. `{reporoot}/dart/looker_sdk/lib/src/sdk/models.dart`
@@ -45,30 +45,30 @@ Run `yarn example` from `{reporoot}/dart/looker_sdk`
4545

4646
### Run tests
4747

48-
Run `yarn test:e2e` from `{reporoot}/dart/looker_sdk` to run end to end tests. Note that this test requires that a `.env` file has been created (see above) and that the Looker instance is running.
48+
Run `yarn test:e2e` from `{reporoot}/dart/looker_sdk` to run end to end tests. Note that these tests require that a `.env` file has been created (see above) and that the Looker instance is running.
4949

5050
Run `yarn test:unit` from `{reporoot}/dart/looker_sdk` to run unit tests. These tests do not require a Looker instance to be running.
5151

5252
Run `yarn test` from `{reporoot}/dart/looker_sdk` to run all tests.
5353

5454
### Run format
5555

56-
Run `yarn format` from `{reporoot}/dart/looker_sdk` to format the `dart` files correctly. This should be run if you change any of the run time library `dart` files. The repo CI will run the linter and will fail if the files have not been correctly formatted.
56+
Run `yarn format` from `{reporoot}/dart/looker_sdk` to format the `dart` files correctly. This should be run if you change any of the run time library `dart` files. The repo CI will run the `format-check` and will fail if the files have not been correctly formatted.
5757

5858
### Run format-check
5959

60-
Run `yarn format-check` from `{reporoot}/dart/looker_sdk` to check the formatting of the `dart` files.
60+
Run `yarn format-check` from `{reporoot}/dart/looker_sdk` to verify the formatting of the `dart` files. This is primarily for CI. It's the same as `yarn format` but does not format the files.
6161

6262
### Run analyze
6363

64-
Run `yarn format-analyze` from `{reporoot}/dart/looker_sdk` to lint the `dart` files.
64+
Run `yarn format-analyze` from `{reporoot}/dart/looker_sdk` to lint the `dart` files. This should be run prior to commiting as CI will this task and will fail if the script fails.
6565

6666
## TODOs
6767

68-
1. Make enum mappers private to package. They are currently public as some enums are not used by by the models and a warning for unused class is diaplayed by visual code. It could also be a bug in either the generator or the spec generator (why are enums being generated if they are not being used?).
69-
2. Add optional timeout option to methods.
68+
1. Make enum mappers private to package. They are currently public as some enums are not used by by the models and a warning for unused class is displayed by visual code. It could also be a bug in either the generator or the spec generator (why are enums being generated if they are not being used?).
69+
2. Add optional timeout parameter to methods and implement timeout support.
7070
3. Add additional authorization methods to api keys.
71-
4. Revisit auth session. There is some duplication of methods in generated methods.
71+
4. Revisit auth session. There is some duplication of code in generated methods.
7272
5. Add base class for models. Move common props to base class. Maybe add some utility methods for primitive types. Should reduce size of models.dart file.
7373
6. More and better generator tests. They are a bit hacky at that moment.
7474
7. Generate dart documentation.

0 commit comments

Comments
 (0)