You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: dart/looker_sdk/README.md
+8-8Lines changed: 8 additions & 8 deletions
Original file line number
Diff line number
Diff line change
@@ -32,7 +32,7 @@ Relies on `yarn` and `dart` being installed. This was developed with `dart` vers
32
32
33
33
### Generate
34
34
35
-
Run `yarn sdk Gen` from the `{reporoot}`. Note that the SDK generator needs to be built `yarn build`. If changing the generator run 'yarn watch` in a separate window. This command generates two files:
35
+
Run `yarn sdk Gen` from the `{reporoot}`. Note that the SDK generator needs to be built using `yarn build`. If changing the generator run 'yarn watch` in a separate window. This command generates two files:
@@ -45,30 +45,30 @@ Run `yarn example` from `{reporoot}/dart/looker_sdk`
45
45
46
46
### Run tests
47
47
48
-
Run `yarn test:e2e` from `{reporoot}/dart/looker_sdk` to run end to end tests. Note that this test requires that a `.env` file has been created (see above) and that the Looker instance is running.
48
+
Run `yarn test:e2e` from `{reporoot}/dart/looker_sdk` to run end to end tests. Note that these tests require that a `.env` file has been created (see above) and that the Looker instance is running.
49
49
50
50
Run `yarn test:unit` from `{reporoot}/dart/looker_sdk` to run unit tests. These tests do not require a Looker instance to be running.
51
51
52
52
Run `yarn test` from `{reporoot}/dart/looker_sdk` to run all tests.
53
53
54
54
### Run format
55
55
56
-
Run `yarn format` from `{reporoot}/dart/looker_sdk` to format the `dart` files correctly. This should be run if you change any of the run time library `dart` files. The repo CI will run the linter and will fail if the files have not been correctly formatted.
56
+
Run `yarn format` from `{reporoot}/dart/looker_sdk` to format the `dart` files correctly. This should be run if you change any of the run time library `dart` files. The repo CI will run the `format-check` and will fail if the files have not been correctly formatted.
57
57
58
58
### Run format-check
59
59
60
-
Run `yarn format-check` from `{reporoot}/dart/looker_sdk` to check the formatting of the `dart` files.
60
+
Run `yarn format-check` from `{reporoot}/dart/looker_sdk` to verify the formatting of the `dart` files. This is primarily for CI. It's the same as `yarn format` but does not format the files.
61
61
62
62
### Run analyze
63
63
64
-
Run `yarn format-analyze` from `{reporoot}/dart/looker_sdk` to lint the `dart` files.
64
+
Run `yarn format-analyze` from `{reporoot}/dart/looker_sdk` to lint the `dart` files. This should be run prior to commiting as CI will this task and will fail if the script fails.
65
65
66
66
## TODOs
67
67
68
-
1. Make enum mappers private to package. They are currently public as some enums are not used by by the models and a warning for unused class is diaplayed by visual code. It could also be a bug in either the generator or the spec generator (why are enums being generated if they are not being used?).
69
-
2. Add optional timeout option to methods.
68
+
1. Make enum mappers private to package. They are currently public as some enums are not used by by the models and a warning for unused class is displayed by visual code. It could also be a bug in either the generator or the spec generator (why are enums being generated if they are not being used?).
69
+
2. Add optional timeout parameter to methods and implement timeout support.
70
70
3. Add additional authorization methods to api keys.
71
-
4. Revisit auth session. There is some duplication of methods in generated methods.
71
+
4. Revisit auth session. There is some duplication of code in generated methods.
72
72
5. Add base class for models. Move common props to base class. Maybe add some utility methods for primitive types. Should reduce size of models.dart file.
73
73
6. More and better generator tests. They are a bit hacky at that moment.
0 commit comments