ci: look for arch-specific snapshots when necessary #977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the 8.x docker images for Logstash are arch-specific (relying on the base install with embedded arch-specific JVM), they no longer will have the same file names we relied on for 7.x causing builds to fail when looking up the URL for the most recent snapshot.
This PR refactors the code that finds the URL for docker image snapshots to find appropriate artifacts, whether the listing includes no-arch or
x86_64
-arch artifacts. It also adds helpful logging when none of the items can be found, and breaks the code into a function for reuse when loading the elasticsearch image.Prior to this change, failure to load a URL resulted in a blind error:
After this change, an error looking up the URL will be much more informative: