-
Notifications
You must be signed in to change notification settings - Fork 307
Index Lifecycle Management Support #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eedf68d
to
e6bb923
Compare
I was wondering if this would also support dynamic index names based on a field of an event, but from what Rob told me this is not possible right now: How bad of an idea would it be to do something like the following to support it being dynamic?
The following issues come to mind:
Just wanted to bring it up as a lot of users rely on the dynamic index creation based on event data |
bfa6e40
to
0fd8594
Compare
Basics work, code is rough, integration test passes
modified: lib/logstash/outputs/elasticsearch/common_configs.rb
Add tests against 6.6 snapshot (first Elasticsearch version to include ILM) and update test against 7.0 to retrieve artifact, rather than attempt to build master.
Add more tests to check correct creation of write alias and templates Tests for default settings
Move into their own module to be mixed in to elasticsearch.rb
Also some test cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @guyboertje! |
Resolves #798