Skip to content

Document that the SINCEDB_DIR variable is the first pick for sincedb #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

magnusbaeck
Copy link
Contributor

Previously it was claimed that the HOME variable was used as the default location of sincedb files, but that statement ignored the SINCEDB_DIR variable which actually takes precedence.

Previously it was claimed that the HOME variable was used as the
default location of sincedb files, but that statement ignored the
SINCEDB_DIR variable which actually takes precedence.
@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@jordansissel
Copy link
Contributor

Alternative proposal: We could remove SINCEDB_DIR support. I think its existence is confusing (two env vars can be used; or some other config settings!) and unnecessary. Thoughts?

@magnusbaeck
Copy link
Contributor Author

Sure, we could deprecate SINCEDB_DIR and remove it 3.0. Doing so will make it harder to get automatically generated sincedb filenames if you don't want the files stored in $HOME since environment variables are the only way to pick directory but leave the filename to Logstash. However, if that's something we want to support, why not allow sincedb_path to be either a file or a directory? Then we could even allow sincedb_path to default to $HOME. I think that would be a cleaner configuration interface.

@magnusbaeck
Copy link
Contributor Author

@jordansissel, can we reach a decision on this one?

@jordansissel
Copy link
Contributor

Sorry for the delay. I am +1 on your proposal to have sincedb_path support
both directory and file name.

On Thursday, February 18, 2016, Magnus Bäck [email protected]
wrote:

Sure, we could deprecate SINCEDB_DIR and remove it 3.0. Doing so will make
it harder to get automatically generated sincedb filenames if you don't
want the files stored in $HOME since environment variables are the only way
to pick directory but leave the filename to Logstash. However, if that's
something we want to support, why not allow sincedb_path to be either a
file or a directory? Then we could even allow sincedb_path to default
to $HOME. I think that would be a cleaner configuration interface.


Reply to this email directly or view it on GitHub
#102 (comment)
.

@magnusbaeck
Copy link
Contributor Author

Closing in favor of issue #106.

@magnusbaeck magnusbaeck closed this Mar 3, 2016
@magnusbaeck magnusbaeck deleted the sincedb_dir branch March 3, 2016 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants