-
Notifications
You must be signed in to change notification settings - Fork 3
Add a hot reloading RIE side implementation #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to this feature! 😁
Added a few nits and suggestions.
Especially the main logic block in RunFileWatcher
would benefit a lot from deconstructing it into smaller functions and introducing a struct for the filewatcher.
A few other suggestions for now:
- separate the debounce from the actual consumption/processing of the changes for more clarity (e.g. the debounce itself could be a wrapper around the channel)
- prefer passing a context instead of a channel for signaling exit/done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit/suggestion, otherwise LGTM
Motivation
We want to provide hot reloading to be able to mount a volume into the container and see changes as they happen. For this, once a change happens, we have to reset the infrastructure, to support reloading (for example, a loaded python module will not change if the source changes, we have to reload it / restart the interpreter).
Changes
Todos