Skip to content

Fix error detection on non-map types #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Sep 29, 2022

Currently, if the result json does not contain a map type as json, but for example an array, boolean, number or null, runtime will panic.
This fixes this, by assuming every error returns a dict, and if its no dict, it cannot be an error.

Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dfangl dfangl merged commit 77fb282 into localstack Sep 29, 2022
@dfangl dfangl deleted the fix-lambda-json-types branch September 29, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants