Switch user and drop privileges #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikschubert
approved these changes
Mar 8, 2023
cmd/localstack/user.go
Outdated
Comment on lines
83
to
92
| func DropPrivileges(userToSwitchTo string) { | ||
| // Lookup user and group IDs for the user we want to switch to. | ||
| userInfo, err := user.Lookup(userToSwitchTo) | ||
| if err != nil { | ||
| log.Errorln("Error looking up user:", userToSwitchTo, err) | ||
| } |
There was a problem hiding this comment.
Suggested change
| func DropPrivileges(userToSwitchTo string) { | |
| // Lookup user and group IDs for the user we want to switch to. | |
| userInfo, err := user.Lookup(userToSwitchTo) | |
| if err != nil { | |
| log.Errorln("Error looking up user:", userToSwitchTo, err) | |
| } | |
| func DropPrivileges(userToSwitchTo string) error { | |
| // Lookup user and group IDs for the user we want to switch to. | |
| userInfo, err := user.Lookup(userToSwitchTo) | |
| if err != nil { | |
| log.Errorln("Error looking up user:", userToSwitchTo, err) | |
| return err | |
| } | |
| ... | |
| return nil |
This is more of a general feedback for the methods in this file. It would generally be better to "fail" early and bubble up the error when receiving an error we don't plan to recover from.
There was a problem hiding this comment.
done for methods without a return value. Should we return a tuple for all methods with return values?
There was a problem hiding this comment.
switched to warn logging for recoverable errors for now
dfangl
requested changes
Mar 8, 2023
dfangl
approved these changes
Mar 8, 2023
Make `GetenvWithDefault` behave like `os.environ.get` in Python
As @dfangl pointed out: Binding port 53 might require root permissions for binding port < 1024 depending on the Docker version moby/moby#41030
dfangl
force-pushed
the
switch-user-and-drop-privileges
branch
from
df38614 to
95959e2
Compare
Using warning level for recoverable warnings rather than breaking errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #12
Switch to
sbx_user1051user for runtime parity and drop root privileges.Limitations
DropPrivilegesbreaks debugging aftersyscall. Debugging before the syscall is possible and resuming (at least) a few lines before the syscall works but stepping over the syscall or any breakpoint beyond the syscalls breaks debugging. Hence, we need to disableDropPrivilegesfor debugging:DropPriviledgesDropPriviledges