WoA LLVM bots config update to improve build time #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since llvm#252 we have got increased build times on WoA build bots. Also WoA 2 stage bot does not collapse the queue because it is not configured to always do a clean build. This patch tries to fix above issues. On both single and 2 stage bots: - Set `LLVM_TARGETS_TO_BUILD` to 'ARM;AArch64;X86'. We only care about these targets on windows. On 2 stage bot: - Set stage 1 LLVM_TARGETS_TO_BUILD to AArch64 only. - Set extra_stage2_cmake_args which overrides extra_cmake_flags. - Disable flang build on stage1 by setting checkout_flang=False. - Enabled `LLVM_ENABLE_PROJECTS=flang;mlir` for stage 2. - Switched to a clean build (`clean=True`) for collapsing queue. - Like stage 1 set stage 2 CLANG_DEFAULT_LINKER to lld. This makes sure just built lld is used by just built clang as default linker.
| testStage1=False, | ||
| extra_cmake_args=[ | ||
| "-DLLVM_TARGETS_TO_BUILD=AArch64", |
There was a problem hiding this comment.
It's obvious in hindsight but if we're not testing stage 1, of course it only needs to be able to produce code for the host. Great thinking!
Every saving helps with this particular build.
| "-DCOMPILER_RT_BUILD_SANITIZERS=OFF"], | ||
| extra_stage2_cmake_args=[ | ||
| "-DLLVM_TARGETS_TO_BUILD='ARM;AArch64;X86'", | ||
| "-DLLVM_ENABLE_PROJECTS=flang;mlir", |
There was a problem hiding this comment.
Is this additive or replacing the projects?
I assume we should have clang and maybe lld in this list.
There was a problem hiding this comment.
clang clang-tools-extra and llvm gets automatically added in both configs. Also we have set checkout_lld=True which will include lld automatically.
There was a problem hiding this comment.
I think it will replace -DLLVM_ENABLE_PROJECTS arg to whatever is defined in f.enable_projects (
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #252 we have got increased build times on WoA build bots. Also WoA 2 stage bot does not collapse the queue because it is not configured to always do a clean build. This patch tries to fix above issues.
On both single and 2 stage bots:
LLVM_TARGETS_TO_BUILDto 'ARM;AArch64;X86'. We only care about these targets on windows.On 2 stage bot:
LLVM_ENABLE_PROJECTS=flang;mlirfor stage 2.clean=True) for collapsing queue.