XFAIL: lld-available lit.cfg tag does not work as intended. #99056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change XFAILs instrprof-gc-sections.c compiler-rt test case because it uses the `lld-available` lit.config tag which erroneously uses the CMAKE_LINKER if it is lld instead of checking for the latest and greatest lld available. A patch is in the works to fix this. This change is to bring the clang-ppc64le-linux-test-suite and clang-ppc64le-linux-multistage back to green as they were broken as of PR llvm#98382
|
@llvm/pr-subscribers-pgo Author: Kamau Bridgeman (kamaub) ChangesThis change XFAILs instrprof-gc-sections.c compiler-rt test case Full diff: https://github.com/llvm/llvm-project/pull/99056.diff 1 Files Affected:
diff --git a/compiler-rt/test/profile/instrprof-gc-sections.c b/compiler-rt/test/profile/instrprof-gc-sections.c
index 8b84c0a242180..06d3eac355638 100644
--- a/compiler-rt/test/profile/instrprof-gc-sections.c
+++ b/compiler-rt/test/profile/instrprof-gc-sections.c
@@ -1,7 +1,7 @@
// REQUIRES: linux, lld-available
// FIXME: Investigate and fix.
-// XFAIL: powerpc64-target-arch
+// XFAIL: powerpc64-target-arch,powerpc64le-target-arch
// RUN: rm -rf %t.profraw
// RUN: %clang_profgen=%t.profraw -fuse-ld=lld -fcoverage-mapping -mllvm -enable-name-compression=false -DCODE=1 -ffunction-sections -fdata-sections -Wl,--gc-sections -o %t %s
|
lei137
reviewed
Jul 16, 2024
| @@ -1,7 +1,7 @@ | |||
| // REQUIRES: linux, lld-available | |||
|
|
|||
| // FIXME: Investigate and fix. | |||
| // XFAIL: powerpc64-target-arch | |||
| // XFAIL: powerpc64-target-arch,powerpc64le-target-arch | |||
There was a problem hiding this comment.
This is only an issue on the 64bit arch? What about 32bit?
There was a problem hiding this comment.
It affects anyone that had lld in their environment but but does not want to test it, this is only fixes the effected bots.
kamaub
commented
Jul 16, 2024
amy-kwan
approved these changes
Jul 16, 2024
kamaub
added a commit
that referenced
this pull request
Jul 16, 2024
PR #99056 marked this test case as an XFAIl for ppc64le but it is actually being temporary unsupported, this changes it from an XFAIl to unsupported.
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
This change XFAILs instrprof-gc-sections.c compiler-rt test case because it uses the `lld-available` lit.config tag which erroneously uses the `CMAKE_LINKER` if it is lld instead of checking for the latest and greatest lld available. A patch is in the works to fix this. This change is to bring the `clang-ppc64le-linux-test-suite` and `clang-ppc64le-linux-multistage` back to green as they were broken as of PR #98382
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: PR #99056 marked this test case as an XFAIl for ppc64le but it is actually being temporary unsupported, this changes it from an XFAIl to unsupported. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251494
jvoung
added a commit
that referenced
this pull request
Aug 27, 2024
…O summaries (#106165) This retries #90692 which was reverted previously due to issues with lld-available being set, even if the copy of lld is not built from source. This does not change any code compared to #90692 to address the lld-available issue. The main change w.r.t, lld-available is xfailing tests in PR #99056 (until a longer term fix is available).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change XFAILs instrprof-gc-sections.c compiler-rt test case
because it uses the
lld-availablelit.config tag which erroneouslyuses the
CMAKE_LINKERif it is lld instead of checking for thelatest and greatest lld available. A patch is in the works to fix
this.
This change is to bring the clang-ppc64le-linux-test-suite and
clang-ppc64le-linux-multistage back to green as they were broken
as of PR #98382