Add a regression test for recent regression in pair. #97355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR llvm#96165 broke code similar to this test, and was subsequently reverted. Add a test-case, to ensure the problem won't reoccur.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: James Y Knight (jyknight) ChangesPR #96165 broke code similar to this test, and was subsequently reverted. Add a test-case, to ensure the problem won't reoccur. Full diff: https://github.com/llvm/llvm-project/pull/97355.diff 1 Files Affected:
diff --git a/libcxx/test/libcxx/utilities/utility/pairs/pairs.pair/pair.incomplete.verify.cpp b/libcxx/test/libcxx/utilities/utility/pairs/pairs.pair/pair.incomplete.verify.cpp
new file mode 100644
index 0000000000000..d0832ea311690
--- /dev/null
+++ b/libcxx/test/libcxx/utilities/utility/pairs/pairs.pair/pair.incomplete.verify.cpp
@@ -0,0 +1,15 @@
+// Check that instantiating pair doesn't look up type traits "too early", before
+// the contained types have been completed.
+//
+// This is a regression test, to prevent a reoccurrance of the issue introduced in
+// 5e1de27f680591a870d78e9952b23f76aed7f456.
+
+// expected-no-diagnostics
+#include <utility>
+#include <vector>
+
+struct Test {
+ std::vector<std::pair<int, Test>> v;
+};
+
+std::pair<int, Test> p;
|
philnik777
reviewed
Jul 2, 2024
| @@ -0,0 +1,15 @@ | |||
| // Check that instantiating pair doesn't look up type traits "too early", before | |||
There was a problem hiding this comment.
Please add a license header
ldionne
approved these changes
Jul 2, 2024
| // This is a regression test, to prevent a reoccurrance of the issue introduced in | ||
| // 5e1de27f680591a870d78e9952b23f76aed7f456. | ||
|
|
||
| // expected-no-diagnostics |
There was a problem hiding this comment.
Let's make this a .compile.pass.cpp test instead of .verify.pass.cpp, that way it can run under all compiler.
jyknight
commented
Jul 2, 2024
| @@ -0,0 +1,15 @@ | |||
| // Check that instantiating pair doesn't look up type traits "too early", before | |||
| // This is a regression test, to prevent a reoccurrance of the issue introduced in | ||
| // 5e1de27f680591a870d78e9952b23f76aed7f456. | ||
|
|
||
| // expected-no-diagnostics |
philnik777
approved these changes
Jul 2, 2024
lravenclaw
pushed a commit
to lravenclaw/llvm-project
that referenced
this pull request
Jul 3, 2024
PR llvm#96165 broke code similar to this test, and was subsequently reverted. Add a test-case, to ensure the problem won't reoccur. This error is potentially related to issues llvm#59292 and llvm#59966.
kbluck
pushed a commit
to kbluck/llvm-project
that referenced
this pull request
Jul 6, 2024
PR llvm#96165 broke code similar to this test, and was subsequently reverted. Add a test-case, to ensure the problem won't reoccur. This error is potentially related to issues llvm#59292 and llvm#59966.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #96165 broke code similar to this test, and was subsequently reverted. Add a test-case, to ensure the problem won't reoccur.
This error is potentially related to issues #59292 and #59966.