Skip to content

[libc][math][c23] Temporarily disable f16fma{,l,f128} on AArch64 #96952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

@llvmbot llvmbot added the libc label Jun 27, 2024
@lntue lntue merged commit aa8409f into llvm:main Jun 27, 2024
6 of 7 checks passed
@llvmbot
Copy link
Member

llvmbot commented Jun 27, 2024

@llvm/pr-subscribers-libc

Author: OverMighty (overmighty)

Changes

See Buildbot failures:


Full diff: https://github.com/llvm/llvm-project/pull/96952.diff

1 Files Affected:

  • (modified) libc/config/linux/aarch64/entrypoints.txt (-9)
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 950dbbe874851..f23b3da06308c 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -508,9 +508,7 @@ if(LIBC_TYPES_HAS_FLOAT16)
     libc.src.math.ceilf16
     libc.src.math.copysignf16
     libc.src.math.f16divf
-    libc.src.math.f16fma
     libc.src.math.f16fmaf
-    libc.src.math.f16fmal
     libc.src.math.f16sqrtf
     libc.src.math.fabsf16
     libc.src.math.fdimf16
@@ -562,13 +560,6 @@ if(LIBC_TYPES_HAS_FLOAT16)
     libc.src.math.ufromfpf16
     libc.src.math.ufromfpxf16
   )
-
-  if(LIBC_TYPES_HAS_FLOAT128)
-    list(APPEND TARGET_LIBM_ENTRYPOINTS
-      # math.h C23 mixed _Float16 and _Float128 entrypoints
-      libc.src.math.f16fmaf128
-    )
-  endif()
 endif()
 
 if(LIBC_TYPES_HAS_FLOAT128)

@nickdesaulniers
Copy link
Member

is there a bug that tracks getting these re-enabled?

@overmighty
Copy link
Member Author

There is #94974 but I haven't updated it since I opened it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants