[llvm] remove unusable llvm.spec.in #96825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `llvm.spec.in` is turned into `llvm.spec` through cmake. The spec file's `%build` section runs `./configure` which has been deprecated since 2016 (See e49730d).
tuliom
approved these changes
Jun 27, 2024
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/744 Here is the relevant piece of the build log for the reference: |
|
I think the failure is unrelated to this change. @tuliom any thoughts? |
|
@kwk Agreed. It looks like this test is failing intermittently, e.g. https://lab.llvm.org/buildbot/#/builders/51/builds/691 |
lravenclaw
pushed a commit
to lravenclaw/llvm-project
that referenced
this pull request
Jul 3, 2024
The `llvm.spec.in` is turned into `llvm.spec` through cmake. The spec file's `%build` section runs `./configure` which has been deprecated since 2016 (See e49730d).
kbluck
pushed a commit
to kbluck/llvm-project
that referenced
this pull request
Jul 6, 2024
The `llvm.spec.in` is turned into `llvm.spec` through cmake. The spec file's `%build` section runs `./configure` which has been deprecated since 2016 (See e49730d).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
llvm.spec.inis turned intollvm.specthrough cmake. The spec file's%buildsection runs./configurewhich has been deprecated since 2016 (See e49730d).