[CI][format] Explicitly pass extensions to git-clang-format #95794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the CI script controls which file extensions are considered instead of letting git-clang-format apply its own filtering rules. In particular, this properly handles libc++ extension-less headers which were passed to git-clang-format, but then dropped by that tool as having an unrecognized extension.
|
✅ With the latest revision this PR passed the Python code formatter. |
|
Please run black, other than that LGTM! It's a bit strange that even if you pass clang-format an explicit list it still filters it, but hey glad we have this workaround |
tru
approved these changes
Jun 17, 2024
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Jun 28, 2024
…lvm#95794)" This reverts commit 7620fe0.
boomanaiden154
added a commit
that referenced
this pull request
Jun 28, 2024
lravenclaw
pushed a commit
to lravenclaw/llvm-project
that referenced
this pull request
Jul 3, 2024
…lvm#95794)" This reverts commit 7620fe0. This patch was causing some significant portion of code formatting jobs to succeed when they should have failed. More investigation is needed. Tracked in llvm#97060.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the CI script controls which file extensions are considered instead of letting git-clang-format apply its own filtering rules. In particular, this properly handles libc++ extension-less headers which were passed to git-clang-format, but then dropped by that tool as having an unrecognized extension.