[TargetLibraryInfo] Use std::move (NFC)

[kazutakahirata]

The std::move here saves 0.11% of heap allocations during the
compilation of a large preprocessed file, namely X86ISelLowering.cpp,
for the X86 target.

[llvmbot]

@llvm/pr-subscribers-llvm-analysis

Author: Kazu Hirata (kazutakahirata)

Changes

The std::move here saves 0.11% of heap allocations during the
compilation of a large preprocessed file, namely X86ISelLowering.cpp,
for the X86 target.

---

Full diff: https://github.com/llvm/llvm-project/pull/95671.diff

1 Files Affected:

• (modified) llvm/include/llvm/Analysis/TargetLibraryInfo.h (+2-1)

diff --git a/llvm/include/llvm/Analysis/TargetLibraryInfo.h b/llvm/include/llvm/Analysis/TargetLibraryInfo.h
index f5da222d11f55..b29046a969448 100644
--- a/llvm/include/llvm/Analysis/TargetLibraryInfo.h
+++ b/llvm/include/llvm/Analysis/TargetLibraryInfo.h
@@ -316,7 +316,8 @@ class TargetLibraryInfo {
   // Provide value semantics.
   TargetLibraryInfo(const TargetLibraryInfo &TLI) = default;
   TargetLibraryInfo(TargetLibraryInfo &&TLI)
-      : Impl(TLI.Impl), OverrideAsUnavailable(TLI.OverrideAsUnavailable) {}
+      : Impl(TLI.Impl),
+        OverrideAsUnavailable(std::move(TLI.OverrideAsUnavailable)) {}
   TargetLibraryInfo &operator=(const TargetLibraryInfo &TLI) = default;
   TargetLibraryInfo &operator=(TargetLibraryInfo &&TLI) {
     Impl = TLI.Impl;

[nikic]

Could you please make the same change in the move assignment operator as well?

[kazutakahirata]

Could you please make the same change in the move assignment operator as well?

Fixed in the latest iteration. Thanks!

[nikic]

LGTM

[nikic]

Looking at this again, you could probably also use = default ... or drop all the explicit ctors/assignment operators and use the implicit ones.

[kazutakahirata]

Looking at this again, you could probably also use = default ... or drop all the explicit ctors/assignment operators and use the implicit ones.

Great idea! We have one user-declared constructor a few lines above, so I would have to use = default to ask the compiler for the default move constructor and move assignment operator. I'll post a follow-up PR.

[kazutakahirata]

I just posted #95685 as a follow-up for this PR.