-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[lldb] Stop testing LLDB on Clang changes in pre-commit CI #95537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) ChangesThis is a temporary measure to alleviate Linux pre-commit CI waiting times that started snowballing recently. I don't intend to overthrow the consensus we reached in #94208, but it shouldn't come at the expense of the whole LLVM community. I'll enable this back as soon as we have news that we got more capacity for Linux pre-commit CI. Full diff: https://github.com/llvm/llvm-project/pull/95537.diff 1 Files Affected:
diff --git a/.ci/generate-buildkite-pipeline-premerge b/.ci/generate-buildkite-pipeline-premerge
index fd603de611e56..98a8b8fff3687 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -74,7 +74,8 @@ function compute-projects-to-test() {
fi
;;
clang)
- for p in clang-tools-extra compiler-rt lldb cross-project-tests; do
+ # lldb is temporarily removed to alleviate Linux pre-commit CI waiting times
+ for p in clang-tools-extra compiler-rt cross-project-tests; do
echo $p
done
;;
|
@llvm/pr-subscribers-lldb Author: Vlad Serebrennikov (Endilll) ChangesThis is a temporary measure to alleviate Linux pre-commit CI waiting times that started snowballing recently. I don't intend to overthrow the consensus we reached in #94208, but it shouldn't come at the expense of the whole LLVM community. I'll enable this back as soon as we have news that we got more capacity for Linux pre-commit CI. Full diff: https://github.com/llvm/llvm-project/pull/95537.diff 1 Files Affected:
diff --git a/.ci/generate-buildkite-pipeline-premerge b/.ci/generate-buildkite-pipeline-premerge
index fd603de611e56..98a8b8fff3687 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -74,7 +74,8 @@ function compute-projects-to-test() {
fi
;;
clang)
- for p in clang-tools-extra compiler-rt lldb cross-project-tests; do
+ # lldb is temporarily removed to alleviate Linux pre-commit CI waiting times
+ for p in clang-tools-extra compiler-rt cross-project-tests; do
echo $p
done
;;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with this as a stopgap measure. @JDevlieghere, are you okay with this as well?
This is a temporary measure to alleviate Linux pre-commit CI waiting times that started snowballing recently.
My initial estimate of 4 additional minutes spent per built seems to be in the right ballpark, but looks like that was the last straw to break camel's back. It seems that CI load got past the tipping point, and now it's not able to burn through the queue over the night on workdays.
I don't intend to overthrow the consensus we reached in #94208, but it shouldn't come at the expense of the whole LLVM community. I'll enable this back as soon as we have news that we got more capacity for Linux pre-commit CI.