[Driver] Add winsysroot alias to the GNU driver

[Andarwinux]

fixes #91216

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-clang

Author: None (Andarwinux)

Changes

fixes #91216

---

Full diff: https://github.com/llvm/llvm-project/pull/95320.diff

1 Files Affected:

• (modified) clang/include/clang/Driver/Options.td (+2)

diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td
index d44faa55c456f..1cce7a5146dd8 100644
--- a/clang/include/clang/Driver/Options.td
+++ b/clang/include/clang/Driver/Options.td
@@ -8569,6 +8569,8 @@ def : Separate<["-"], "Xmicrosoft-windows-sdk-root">,
     Alias<_SLASH_winsdkdir>;
 def : Separate<["-"], "Xmicrosoft-windows-sdk-version">,
     Alias<_SLASH_winsdkversion>;
+def : Separate<["-"], "Xmicrosoft-windows-sys-root">,
+    Alias<_SLASH_winsysroot>;
 
 // Ignored:
 

[mstorsjo]

What's the deal with constantly force-pushing an update to the PR, with the exact same contents? With the massive inflow of commits in LLVM, you can't rebase your branch constantly on top of the latest one many times per day, I would say.

And what's going on when #94731 was closed and now this one is reopened?

[zmodem]

lgtm

A test would be nice, but I see the other flags added in f1440bf don't have tests either, so maybe it's okay.

[compnerd]

@zmodem - they are aliases after all. I think that core logic being tested is sufficient. I can see the value in testing that the flags are honoured, but the tests would be of low value IMO. They just test the flags are listed.

[zmodem]

I didn't realize this hadn't been merged already. I'll go ahead and push the button.

[github-actions]

@Andarwinux Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!