Skip to content

[Offload][NFCI] Initialize the KernelArgsTy to default values #95117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions offload/include/Shared/APITypes.h
Original file line number Diff line number Diff line change
Expand Up @@ -89,22 +89,26 @@ struct __tgt_async_info {

/// This struct contains all of the arguments to a target kernel region launch.
struct KernelArgsTy {
uint32_t Version; // Version of this struct for ABI compatibility.
uint32_t NumArgs; // Number of arguments in each input pointer.
void **ArgBasePtrs; // Base pointer of each argument (e.g. a struct).
void **ArgPtrs; // Pointer to the argument data.
int64_t *ArgSizes; // Size of the argument data in bytes.
int64_t *ArgTypes; // Type of the data (e.g. to / from).
void **ArgNames; // Name of the data for debugging, possibly null.
void **ArgMappers; // User-defined mappers, possibly null.
uint64_t Tripcount; // Tripcount for the teams / distribute loop, 0 otherwise.
uint32_t Version = 0; // Version of this struct for ABI compatibility.
uint32_t NumArgs = 0; // Number of arguments in each input pointer.
void **ArgBasePtrs =
nullptr; // Base pointer of each argument (e.g. a struct).
void **ArgPtrs = nullptr; // Pointer to the argument data.
int64_t *ArgSizes = nullptr; // Size of the argument data in bytes.
int64_t *ArgTypes = nullptr; // Type of the data (e.g. to / from).
void **ArgNames = nullptr; // Name of the data for debugging, possibly null.
void **ArgMappers = nullptr; // User-defined mappers, possibly null.
uint64_t Tripcount =
0; // Tripcount for the teams / distribute loop, 0 otherwise.
struct {
uint64_t NoWait : 1; // Was this kernel spawned with a `nowait` clause.
uint64_t Unused : 63;
} Flags;
uint32_t NumTeams[3]; // The number of teams (for x,y,z dimension).
uint32_t ThreadLimit[3]; // The number of threads (for x,y,z dimension).
uint32_t DynCGroupMem; // Amount of dynamic cgroup memory requested.
} Flags = {0, 0};
// The number of teams (for x,y,z dimension).
uint32_t NumTeams[3] = {0, 0, 0};
// The number of threads (for x,y,z dimension).
uint32_t ThreadLimit[3] = {0, 0, 0};
uint32_t DynCGroupMem = 0; // Amount of dynamic cgroup memory requested.
};
static_assert(sizeof(KernelArgsTy().Flags) == sizeof(uint64_t),
"Invalid struct size");
Expand Down
Loading