Skip to content

Document that llvm-lit needs to be run to collect static metrics #94836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

hiraditya
Copy link
Collaborator

No description provided.

@hiraditya hiraditya requested a review from ilovepi June 8, 2024 04:08
@v01dXYZ

This comment was marked as off-topic.

Copy link
Contributor

@ilovepi ilovepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the one comment.

@hiraditya
Copy link
Collaborator Author

Yes, actually compile_time metrics has already produced by running make/ninja and lit is just aggregating the .o.time per directory. Cf litsupport/modules/compiletime

Just to ask because I didn t find it, how to have a repeated build to have at least a averaged compile_time ? When we use perf there is the -r option but the wrapper script timeit.sh don t allow to add any options.

Does this help:
https://llvm.org/docs/TestSuiteGuide.html#displaying-and-analyzing-results

@v01dXYZ
Copy link
Contributor

v01dXYZ commented Jun 8, 2024

@hiraditya sorry i was tryharding I should have open an issue instead. Running lit don t rebuild anything. So the result for compile time are noisy and there is no way to estimate the variance and know if the number is statically significant.
That's quite a PITA for sharing reliable results to others.

@hiraditya
Copy link
Collaborator Author

@hiraditya sorry i was tryharding I should have open an issue instead. Running lit don t rebuild anything. So the result for compile time are noisy and there is no way to estimate the variance and know if the number is statically significant. That's quite a PITA for sharing reliable results to others.

yeah please open a separate issue.

@hiraditya hiraditya merged commit caf2de7 into llvm:main Jun 10, 2024
8 checks passed
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Jun 12, 2024
@HerrCai0907 HerrCai0907 mentioned this pull request Jun 13, 2024
@hiraditya hiraditya deleted the gvnsink_dbg branch December 4, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants