[lldb] Include memory stats in statistics summary

[bulbazord]

The summary already includes other size information, e.g. total debug info size in bytes. The only other way I can get this information is by dumping all statistics which can be quite large. Adding it to the summary seems fair.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Alex Langford (bulbazord)

Changes

The summary already includes other size information, e.g. total debug info size in bytes. The only other way I can get this information is by dumping all statistics which can be quite large. Adding it to the summary seems fair.

---

Full diff: https://github.com/llvm/llvm-project/pull/94671.diff

1 Files Affected:

• (modified) lldb/source/Target/Statistics.cpp (+5-5)

diff --git a/lldb/source/Target/Statistics.cpp b/lldb/source/Target/Statistics.cpp
index be0848573f812..2a5300012511a 100644
--- a/lldb/source/Target/Statistics.cpp
+++ b/lldb/source/Target/Statistics.cpp
@@ -355,14 +355,14 @@ llvm::json::Value DebuggerStats::ReportStatistics(
   }
   global_stats.try_emplace("targets", std::move(json_targets));
 
+  ConstStringStats const_string_stats;
+  json::Object json_memory{
+      {"strings", const_string_stats.ToJSON()},
+  };
+  global_stats.try_emplace("memory", std::move(json_memory));
   if (!summary_only) {
-    ConstStringStats const_string_stats;
-    json::Object json_memory{
-        {"strings", const_string_stats.ToJSON()},
-    };
     json::Value cmd_stats = debugger.GetCommandInterpreter().GetStatistics();
     global_stats.try_emplace("modules", std::move(json_modules));
-    global_stats.try_emplace("memory", std::move(json_memory));
     global_stats.try_emplace("commands", std::move(cmd_stats));
   }
 

[kusmour]

The memory section is reasonably small to be in the summary

  "memory": {
    "strings": {
      "bytesTotal": 3145728,
      "bytesUnused": 1426827,
      "bytesUsed": 1718901
    }
  },

LGTM!

[bulbazord]

Ah, I see there was a test for this that I missed. I've gotten an email about it, taking a look now.

Failed Tests (1):
  lldb-api :: functionalities/stats_api/TestStatisticsAPI.py

[bulbazord]

Fix: #94683