[llvm-reduce] Remove DIGlobalVariableExpressions from DICompileUnit's globals #94497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… globals The 'metadata' delta pass will remove !dbg attachments from globals (which are DIGlobalVariableExpression nodes). The DIGlobalVariableExpressions don't get eliminated from the IR however if they are still referenced by the globals field in DICompileUnit. Teach the 'di-metadata' pass to try removing global variable operands from metadata tuples as well as DINodes.
ormris
reviewed
Jun 5, 2024
| @@ -15,18 +15,15 @@ | |||
| ; CHECK-INTERESTINGNESS-DAG: [[SUBPROG]] = distinct !DISubprogram(name: "test", | |||
|
|
|||
|
|
|||
|
|
|||
|
|
||
| TN.push_back(Tup->getOperand(I)); | ||
| if (Metadata *Op = Tup->getOperand(I).get()) { | ||
| if (isa<DINode>(Op) || isa<DIGlobalVariableExpression>(Op)) { |
There was a problem hiding this comment.
I believe it is possible to find nulls in the MD tree. Given the brute-force approach of this pass, I think isa_and_nonnull makes more sense.
There was a problem hiding this comment.
I've guarded it with if (Metadata *Op = Tup->getOperand(I).get()) above this line
There was a problem hiding this comment.
Ah yes. That's fine, then. One nit: The braces on this if statement are not necessary.
|
Thanks @ormris - I've addressed your comments |
ormris
approved these changes
Jun 5, 2024
|
|
||
| TN.push_back(Tup->getOperand(I)); | ||
| if (Metadata *Op = Tup->getOperand(I).get()) { | ||
| if (isa<DINode>(Op) || isa<DIGlobalVariableExpression>(Op)) { |
There was a problem hiding this comment.
Ah yes. That's fine, then. One nit: The braces on this if statement are not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'metadata' delta pass will remove !dbg attachments from globals (which are DIGlobalVariableExpression nodes). The DIGlobalVariableExpressions don't get eliminated from the IR however if they are still referenced by the globals field in DICompileUnit.
Teach the 'di-metadata' pass to try removing global variable operands from metadata tuples as well as DINodes.