[lldb] Disable find-module.test in case of a remote target #94165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The target arch is `i386-pc-windows` after loading the dump. It updates to `i386-pc-windows-msvc` or `i386-pc-windows-gnu` in lldb\source\Plugins\Process\minidump\ProcessMinidump.cpp, line 218 ``` GetTarget().MergeArchitecture(module->GetArchitecture()); ``` But in case of the remote target (`remote-linux`) and the `Windows host` lldb executed the following commands at the beginning ``` platform select remote-linux platform connect connect://<ip>:<port> ``` and then the target arch is `i386-pc-windows-msvc` immediately after loading the dump. GetTarget().MergeArchitecture(module->GetArchitecture()) does not update it to `i386-pc-windows-gnu` when the module arch is `i386-pc-windows-gnu`.
|
@llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) ChangesThe target arch is But in case of the remote target ( and then the target arch is Full diff: https://github.com/llvm/llvm-project/pull/94165.diff 1 Files Affected:
diff --git a/lldb/test/Shell/Minidump/Windows/find-module.test b/lldb/test/Shell/Minidump/Windows/find-module.test
index 7ac2f74f8039b..b3a7ec36520f0 100644
--- a/lldb/test/Shell/Minidump/Windows/find-module.test
+++ b/lldb/test/Shell/Minidump/Windows/find-module.test
@@ -1,6 +1,8 @@
Test that we correctly find a PE/COFF file in our executable search path, and
use it when opening minidumps.
+UNSUPPORTED: remote{{.*}}
+
RUN: yaml2obj %S/Inputs/find-module.exe.yaml -o %T/find-module.exe
RUN: yaml2obj %S/Inputs/find-module.dmp.yaml -o %T/find-module.dmp
RUN: %lldb -O "settings set target.exec-search-paths %T" \
|
|
It is the last show stopper |
labath
approved these changes
Nov 14, 2024
Co-authored-by: Pavel Labath <[email protected]>
slydiman
added a commit
to slydiman/llvm-project
that referenced
this pull request
Nov 14, 2024
Changing from UNSUPPOERTED to XFAIL in llvm#94165 break x86 linux host / Aarch64 linux target build https://lab.llvm.org/buildbot/#/builders/195/builds/1047
slydiman
added a commit
that referenced
this pull request
Nov 14, 2024
Changing from UNSUPPOERTED to XFAIL in #94165 break x86 linux host / Aarch64 linux target build https://lab.llvm.org/buildbot/#/builders/195/builds/1047
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The target arch is
i386-pc-windowsafter loading the dump. It updates toi386-pc-windows-msvcori386-pc-windows-gnuin lldb\source\Plugins\Process\minidump\ProcessMinidump.cpp, line 218But in case of the remote target (
remote-linux) and theWindows hostlldb executed the following commands at the beginningand then the target arch is
i386-pc-windows-msvcimmediately after loading the dump. GetTarget().MergeArchitecture(module->GetArchitecture()) does not update it toi386-pc-windows-gnuwhen the module arch isi386-pc-windows-gnu.