Skip to content

Revert "Set ObjectFile's assignment operator to also be deleted like its copy constructor" #92973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2024

Conversation

fsfod
Copy link
Contributor

@fsfod fsfod commented May 21, 2024

Reverts #92942

@llvmbot
Copy link
Member

llvmbot commented May 21, 2024

@llvm/pr-subscribers-llvm-binary-utilities

Author: Thomas Fransham (fsfod)

Changes

Reverts llvm/llvm-project#92942


Full diff: https://github.com/llvm/llvm-project/pull/92973.diff

1 Files Affected:

  • (modified) llvm/include/llvm/Object/ObjectFile.h (-1)
diff --git a/llvm/include/llvm/Object/ObjectFile.h b/llvm/include/llvm/Object/ObjectFile.h
index a50766ccaeb89..8c868c7643edc 100644
--- a/llvm/include/llvm/Object/ObjectFile.h
+++ b/llvm/include/llvm/Object/ObjectFile.h
@@ -302,7 +302,6 @@ class ObjectFile : public SymbolicFile {
 public:
   ObjectFile() = delete;
   ObjectFile(const ObjectFile &other) = delete;
-  ObjectFile &opeartor = (const ObjectFile &other) = delete;
 
   uint64_t getCommonSymbolSize(DataRefImpl Symb) const {
     Expected<uint32_t> SymbolFlagsOrErr = getSymbolFlags(Symb);

Copy link
Collaborator

@dyung dyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Did you see the comment I left in the original review?

@fsfod
Copy link
Contributor Author

fsfod commented May 21, 2024

yes, i just thought this was was quickest way to unbeak the build.

@dyung
Copy link
Collaborator

dyung commented May 21, 2024

Are you able to submit the revert or do you need it submitted for you?

@fsfod
Copy link
Contributor Author

fsfod commented May 21, 2024

i need it submitted

@dyung dyung merged commit 7630775 into llvm:main May 21, 2024
5 of 6 checks passed
@fsfod fsfod deleted the revert-92942-del_assignment_op branch October 14, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants