Skip to content

SBDebugger: define callback_token_t for win32 #92870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

antmox
Copy link
Contributor

@antmox antmox commented May 21, 2024

fix lldb-aarch64-windows bot failure introduced by #89868 https://lab.llvm.org/buildbot/#/builders/219/builds/11583

@antmox antmox requested a review from JDevlieghere as a code owner May 21, 2024 07:24
@llvmbot llvmbot added the lldb label May 21, 2024
@llvmbot
Copy link
Member

llvmbot commented May 21, 2024

@llvm/pr-subscribers-lldb

Author: antoine moynault (antmox)

Changes

fix lldb-aarch64-windows bot failure introduced by #89868 https://lab.llvm.org/buildbot/#/builders/219/builds/11583


Full diff: https://github.com/llvm/llvm-project/pull/92870.diff

1 Files Affected:

  • (modified) lldb/include/lldb/lldb-types.h (+1)
diff --git a/lldb/include/lldb/lldb-types.h b/lldb/include/lldb/lldb-types.h
index 8e717c62d3259..6b9289f0a0743 100644
--- a/lldb/include/lldb/lldb-types.h
+++ b/lldb/include/lldb/lldb-types.h
@@ -47,6 +47,7 @@ typedef void *thread_arg_t;                       // Host thread argument type
 typedef unsigned thread_result_t;                 // Host thread result type
 typedef thread_result_t (*thread_func_t)(void *); // Host thread function type
 typedef void *pipe_t;                             // Host pipe type is HANDLE
+typedef int callback_token_t;
 
 #else
 

@mstorsjo
Copy link
Member

+1, this fixes my build errors for Windows targets as well: https://github.com/mstorsjo/llvm-mingw/actions/runs/9167001362/job/25206642195

@labath
Copy link
Collaborator

labath commented May 21, 2024

Moving the typedef out of platform-specific code would be a better, as this is not in any way platform-specific. I just pushed something along those lines.

@antmox antmox closed this May 21, 2024
@antmox antmox deleted the fix_callback_token_win branch May 21, 2024 09:53
@antmox
Copy link
Contributor Author

antmox commented May 21, 2024

fixed elsewhere

@royitaqi
Copy link
Contributor

Thanks to @antmox and @labath for fixing this. My apologies for breaking the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants