[mlir] add missing include to MemRefTransformOps.h #92361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ODS-generated code has the following:
```
::mlir::TypedValue<::mlir::transform::OperationType> getAlloca() {
return ::llvm::cast<::mlir::TypedValue<::mlir::transform::OperationType>>(
*getODSOperands(0).begin());
}
```
that may require the compiler seing the definition of `OperationType` so
include the corresponding header.
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-memref Author: Oleksandr "Alex" Zinenko (ftynse) ChangesThe ODS-generated code has the following: that may require the compiler seing the definition of Full diff: https://github.com/llvm/llvm-project/pull/92361.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/MemRef/TransformOps/MemRefTransformOps.h b/mlir/include/mlir/Dialect/MemRef/TransformOps/MemRefTransformOps.h
index a87767acdd3b8..5ef901ade91d1 100644
--- a/mlir/include/mlir/Dialect/MemRef/TransformOps/MemRefTransformOps.h
+++ b/mlir/include/mlir/Dialect/MemRef/TransformOps/MemRefTransformOps.h
@@ -10,6 +10,7 @@
#define MLIR_DIALECT_MEMREF_TRANSFORMOPS_MEMREFTRANSFORMOPS_H
#include "mlir/Bytecode/BytecodeOpInterface.h"
+#include "mlir/Dialect/Transform/IR/TransformTypes.h"
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
#include "mlir/IR/OpImplementation.h"
|
nicolasvasilache
approved these changes
May 16, 2024
qiaojbao
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Jun 26, 2024
…02b412774 Local branch amd-gfx 15202b4 Revert blending-shuffle tests Remote branch main e3ed9e3 [mlir] add missing include to MemRefTransformOps.h (llvm#92361)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ODS-generated code has the following:
that may require the compiler seing the definition of
OperationTypeso include the corresponding header.