Skip to content

[Modules] Enable MS Windows test for implicit-module-no-timestamp.cpp #91738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ivanmurashko
Copy link
Contributor

@ivanmurashko ivanmurashko commented May 10, 2024

There is a follow-up commit for #90319. The Windows test was disabled in that commit, but it should pass on this operating system. Therefore, it would be beneficial to have it enabled for MS Windows.

The test should pass on MS Windows and it would be good to have it
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:modules C++20 modules and Clang Header Modules labels May 10, 2024
@llvmbot
Copy link
Member

llvmbot commented May 10, 2024

@llvm/pr-subscribers-clang-modules

@llvm/pr-subscribers-clang

Author: Ivan Murashko (ivanmurashko)

Changes

There is a followup commit for #90319. The windows test was disabled at that commit but it should pass on MS Windows and it would be good to have it enabled.


Full diff: https://github.com/llvm/llvm-project/pull/91738.diff

1 Files Affected:

  • (modified) clang/test/Modules/implicit-module-no-timestamp.cpp (-1)
diff --git a/clang/test/Modules/implicit-module-no-timestamp.cpp b/clang/test/Modules/implicit-module-no-timestamp.cpp
index 1b681a610bab2..50767b4a11468 100644
--- a/clang/test/Modules/implicit-module-no-timestamp.cpp
+++ b/clang/test/Modules/implicit-module-no-timestamp.cpp
@@ -1,4 +1,3 @@
-// UNSUPPORTED: system-windows
 // RUN: rm -rf %t
 // RUN: split-file %s %t
 // RUN: cd %t

@ivanmurashko
Copy link
Contributor Author

@dmpolukhin , the test was successfully passed on MS Windows. There is the corresponding record from the build log

�_bk;t=1715380522596�PASS: Clang :: Modules/implicit-module-no-timestamp.cpp (12618 of 20053)

@dmpolukhin dmpolukhin closed this May 11, 2024
@dmpolukhin dmpolukhin reopened this May 11, 2024
@dmpolukhin dmpolukhin self-requested a review May 11, 2024 21:52
@ivanmurashko ivanmurashko merged commit 91c917b into llvm:main May 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:modules C++20 modules and Clang Header Modules clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants