[flang][CMake] Add missing dependency to generate Fortran module files #91517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjklemm
requested review from
tblah,
banach-space,
kiranchandramohan and
Meinersbur
Meinersbur
approved these changes
May 8, 2024
| @@ -432,7 +432,7 @@ if(runtimes) | |||
| # TODO: This is a workaround until flang becomes a first-class project | |||
| # in llvm/CMakeList.txt. Until then, this line ensures that flang-new is | |||
| # built before "openmp" is built as a runtime project. | |||
| list(APPEND extra_deps "flang-new") | |||
| list(APPEND extra_deps "flang-new" "module_files") | |||
There was a problem hiding this comment.
Could you add a comment on why the module_files is required here?
There was a problem hiding this comment.
Was the issue present only in out-of-tree builds? How did this work correctly in in-tree builds without this change?
kiranchandramohan
approved these changes
May 8, 2024
| @@ -432,7 +432,7 @@ if(runtimes) | |||
| # TODO: This is a workaround until flang becomes a first-class project | |||
| # in llvm/CMakeList.txt. Until then, this line ensures that flang-new is | |||
| # built before "openmp" is built as a runtime project. | |||
| list(APPEND extra_deps "flang-new") | |||
| list(APPEND extra_deps "flang-new" "module_files") | |||
There was a problem hiding this comment.
Was the issue present only in out-of-tree builds? How did this work correctly in in-tree builds without this change?
|
The issue was present in runtime builds of OpenMP, but was more like a race condition with some succesful builds and some failing. Esp. for stage2 builds it failed more consistently. I guess regular project build were not affected, as all targets had been build in order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug #90769. Many thanks to @Meinersbur for providing the initial thought and solution to this.