Skip to content

[mlir] Update comment about propertiesAttr (NFC) #89631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[mlir] Update comment about propertiesAttr (NFC) #89631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions mlir/include/mlir/IR/OperationSupport.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,9 +960,12 @@ struct OperationState {
/// Regions that the op will hold.
SmallVector<std::unique_ptr<Region>, 1> regions;

// If we're creating an unregistered operation, this Attribute is used to
// build the properties. Otherwise it is ignored. For registered operations
// see the `getOrAddProperties` method.
// This Attribute is used to opaquely construct the properties of the
// operation. If we're creating an unregistered operation, the Attribute is
// used as-is as the Properties storage of the operation. Otherwise, the
// operation properties are constructed opaquely using its
// `setPropertiesFromAttr` hook. Note that `getOrAddProperties` is the
// preferred method to construct properties from C++.
Attribute propertiesAttr;

private:
Expand Down