[libc][fenv] Remove unnecessary dependencies #88788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-libc Author: Robin Caloudis (robincaloudis) ChangesWhyNot needed. WhatRemove dependencies from CMake files. We do not have to worry about Bazel build files as these dependencies are not present. Full diff: https://github.com/llvm/llvm-project/pull/88788.diff 1 Files Affected:
diff --git a/libc/src/fenv/CMakeLists.txt b/libc/src/fenv/CMakeLists.txt
index a28a7ca4c2d821..17e99474120627 100644
--- a/libc/src/fenv/CMakeLists.txt
+++ b/libc/src/fenv/CMakeLists.txt
@@ -17,7 +17,6 @@ add_entrypoint_object(
HDRS
fesetround.h
DEPENDS
- libc.hdr.fenv_macros
libc.src.__support.FPUtil.fenv_impl
COMPILE_OPTIONS
-O2
@@ -30,7 +29,6 @@ add_entrypoint_object(
HDRS
feclearexcept.h
DEPENDS
- libc.hdr.fenv_macros
libc.src.__support.FPUtil.fenv_impl
COMPILE_OPTIONS
-O2
@@ -43,7 +41,6 @@ add_entrypoint_object(
HDRS
feraiseexcept.h
DEPENDS
- libc.hdr.fenv_macros
libc.src.__support.FPUtil.fenv_impl
COMPILE_OPTIONS
-O2
@@ -56,7 +53,6 @@ add_entrypoint_object(
HDRS
fetestexcept.h
DEPENDS
- libc.hdr.fenv_macros
libc.src.__support.FPUtil.fenv_impl
COMPILE_OPTIONS
-O2
@@ -69,7 +65,6 @@ add_entrypoint_object(
HDRS
fegetenv.h
DEPENDS
- libc.hdr.fenv_macros
libc.hdr.types.fenv_t
libc.src.__support.FPUtil.fenv_impl
COMPILE_OPTIONS
@@ -83,7 +78,6 @@ add_entrypoint_object(
HDRS
fesetenv.h
DEPENDS
- libc.hdr.fenv_macros
libc.hdr.types.fenv_t
libc.src.__support.FPUtil.fenv_impl
COMPILE_OPTIONS
@@ -111,7 +105,6 @@ add_entrypoint_object(
HDRS
fesetexcept.h
DEPENDS
- libc.hdr.fenv_macros
libc.src.__support.FPUtil.fenv_impl
COMPILE_OPTIONS
-O2
@@ -166,7 +159,6 @@ add_entrypoint_object(
HDRS
feenableexcept.h
DEPENDS
- libc.hdr.fenv_macros
libc.src.__support.FPUtil.fenv_impl
COMPILE_OPTIONS
-O2
@@ -179,7 +171,6 @@ add_entrypoint_object(
HDRS
fedisableexcept.h
DEPENDS
- libc.hdr.fenv_macros
libc.src.__support.FPUtil.fenv_impl
COMPILE_OPTIONS
-O2
@@ -192,7 +183,6 @@ add_entrypoint_object(
HDRS
fegetexcept.h
DEPENDS
- libc.hdr.fenv_macros
libc.src.__support.FPUtil.fenv_impl
COMPILE_OPTIONS
-O2
|
nickdesaulniers
approved these changes
Apr 15, 2024
|
Yes, this would be great. I lack write access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the fenv macro dependency from the CMake files as the underlying targets do not make use of it. Note that we do not have to worry about corresponding Bazel targets, as they look good.