Skip to content

[libc][fenv] Use proxy header #88787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

robincaloudis
Copy link
Contributor

@robincaloudis robincaloudis commented Apr 15, 2024

Include types fexcept_t and fenv_t from corresponding proxy headers, as they are available since #88467.

@robincaloudis robincaloudis changed the title [libc][fenv] Use proxy header [libc][fenv] Use proxy headers Apr 15, 2024
@robincaloudis robincaloudis changed the title [libc][fenv] Use proxy headers [libc][fenv] Use proxy header Apr 15, 2024
@robincaloudis robincaloudis marked this pull request as ready for review April 15, 2024 20:42
@llvmbot llvmbot added the libc label Apr 15, 2024
@llvmbot
Copy link
Member

llvmbot commented Apr 15, 2024

@llvm/pr-subscribers-libc

Author: Robin Caloudis (robincaloudis)

Changes

Why

Available since #88467.

What

Make use of them.


Full diff: https://github.com/llvm/llvm-project/pull/88787.diff

3 Files Affected:

  • (modified) libc/src/fenv/fegetexceptflag.h (+1-1)
  • (modified) libc/src/fenv/fesetexceptflag.h (+1-1)
  • (modified) libc/src/fenv/feupdateenv.cpp (+1-1)
diff --git a/libc/src/fenv/fegetexceptflag.h b/libc/src/fenv/fegetexceptflag.h
index ad72161e536f83..fcb9598658d43b 100644
--- a/libc/src/fenv/fegetexceptflag.h
+++ b/libc/src/fenv/fegetexceptflag.h
@@ -9,7 +9,7 @@
 #ifndef LLVM_LIBC_SRC_FENV_FEGETEXCEPTFLAG_H
 #define LLVM_LIBC_SRC_FENV_FEGETEXCEPTFLAG_H
 
-#include <fenv.h>
+#include "hdr/types/fexcept_t.h"
 
 namespace LIBC_NAMESPACE {
 
diff --git a/libc/src/fenv/fesetexceptflag.h b/libc/src/fenv/fesetexceptflag.h
index 15e62eda1b840c..a018358dc9dfcc 100644
--- a/libc/src/fenv/fesetexceptflag.h
+++ b/libc/src/fenv/fesetexceptflag.h
@@ -9,7 +9,7 @@
 #ifndef LLVM_LIBC_SRC_FENV_FESETEXCEPTFLAG_H
 #define LLVM_LIBC_SRC_FENV_FESETEXCEPTFLAG_H
 
-#include <fenv.h>
+#include "hdr/types/fexcept_t.h"
 
 namespace LIBC_NAMESPACE {
 
diff --git a/libc/src/fenv/feupdateenv.cpp b/libc/src/fenv/feupdateenv.cpp
index 7e81b9476da91b..06648635381555 100644
--- a/libc/src/fenv/feupdateenv.cpp
+++ b/libc/src/fenv/feupdateenv.cpp
@@ -10,7 +10,7 @@
 #include "src/__support/FPUtil/FEnvImpl.h"
 #include "src/__support/common.h"
 
-#include <fenv.h>
+#include "hdr/types/fenv_t.h"
 
 namespace LIBC_NAMESPACE {
 

@nickdesaulniers nickdesaulniers self-assigned this Apr 15, 2024
Copy link
Member

@nickdesaulniers nickdesaulniers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for the patch!

Do you need us to merge this for you?

@robincaloudis
Copy link
Contributor Author

Yes, this would be great. I lack write access.

@nickdesaulniers nickdesaulniers merged commit a79783d into llvm:main Apr 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants