[LoongArch] Return true from shouldConsiderGEPOffsetSplit #88371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-llvm-transforms @llvm/pr-subscribers-backend-loongarch Author: wanglei (wangleiat) ChangesSimilar to commit 2e46312. Full diff: https://github.com/llvm/llvm-project/pull/88371.diff 1 Files Affected:
diff --git a/llvm/lib/Target/LoongArch/LoongArchISelLowering.h b/llvm/lib/Target/LoongArch/LoongArchISelLowering.h
index 9e9ac0b8269291..4bb6c049f8d758 100644
--- a/llvm/lib/Target/LoongArch/LoongArchISelLowering.h
+++ b/llvm/lib/Target/LoongArch/LoongArchISelLowering.h
@@ -238,6 +238,7 @@ class LoongArchTargetLowering : public TargetLowering {
bool isShuffleMaskLegal(ArrayRef<int> Mask, EVT VT) const override {
return false;
}
+ bool shouldConsiderGEPOffsetSplit() const override { return true; }
private:
/// Target-specific function used to lower LoongArch calling conventions.
|
If not performing gep splits can prevent important optimizations, such as preventing the element indices / member offsets from being (partially) folded into load/store instruction immediates.
SixWeining
approved these changes
Apr 14, 2024
bazuzi
pushed a commit
to bazuzi/llvm-project
that referenced
this pull request
Apr 15, 2024
If not performing gep splits can prevent important optimizations, such as preventing the element indices / member offsets from being (partially) folded into load/store instruction immediates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not performing gep splits can prevent important
optimizations, such as preventing the element indices / member offsets from
being (partially) folded into load/store instruction immediates.