Skip to content

[BOLT] Add BB index to BAT #86044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 22, 2024
Merged

Conversation

aaupov
Copy link
Contributor

@aaupov aaupov commented Mar 20, 2024

Add input basic block index to BAT metadata. This addresses
the case where some basic blocks are eliminated, and output
index is not equal to the input block index. These indices
are used in non-stale-matching mode.

Increases BAT section size to:

  • large binary: 39521512 bytes (1.02x original),
  • medium binary: 3799988 bytes (0.64x),
  • small binary: 920 bytes (0.64x).

Test Plan: Updated bolt-address-translation{,-yaml}.test

aaupov added 2 commits March 20, 2024 16:52
Created using spr 1.3.4
aaupov and others added 9 commits March 20, 2024 17:08
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
Created using spr 1.3.4
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
Copy link
Contributor

@rafaelauler rafaelauler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@aaupov aaupov changed the base branch from users/aaupov/spr/main.bolt-add-bb-index-to-bat to main March 22, 2024 13:07
@aaupov aaupov merged commit 3b3de48 into main Mar 22, 2024
@aaupov aaupov deleted the users/aaupov/spr/bolt-add-bb-index-to-bat branch March 22, 2024 13:07
banach-space added a commit to banach-space/llvm-project that referenced this pull request Mar 22, 2024
aaupov added a commit that referenced this pull request Mar 22, 2024
@aaupov
Copy link
Contributor Author

aaupov commented Mar 22, 2024

Apologies for including unrelated changes. Will reland cleanly.

aaupov added a commit that referenced this pull request Mar 22, 2024
Add input basic block index to BAT metadata. This addresses the case
where some basic blocks are eliminated, and output index is not equal
to the input block index. These indices are used in non-stale-matching
mode.

Increases BAT section size to:
- large binary: 39521512 bytes (1.02x original),
- medium binary: 3799988 bytes (0.64x),
- small binary: 920 bytes (0.64x).

Test Plan:
Updated bolt-address-translation{,-yaml}.test

Pull Request: #86044
chencha3 pushed a commit to chencha3/llvm-project that referenced this pull request Mar 23, 2024
chencha3 pushed a commit to chencha3/llvm-project that referenced this pull request Mar 23, 2024
chencha3 pushed a commit to chencha3/llvm-project that referenced this pull request Mar 23, 2024
Add input basic block index to BAT metadata. This addresses the case
where some basic blocks are eliminated, and output index is not equal
to the input block index. These indices are used in non-stale-matching
mode.

Increases BAT section size to:
- large binary: 39521512 bytes (1.02x original),
- medium binary: 3799988 bytes (0.64x),
- small binary: 920 bytes (0.64x).

Test Plan:
Updated bolt-address-translation{,-yaml}.test

Pull Request: llvm#86044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants