Skip to content

[mlir][cmake] Enable -Wundef. #84011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2024
Merged

[mlir][cmake] Enable -Wundef. #84011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed2dfcf
[mlir][cmake] Enable -Wundef.
ingomueller-net Mar 5, 2024
916e4ba
Add rationale to cmake-config.h.cmake.
ingomueller-net Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mlir/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,12 @@ endif()
check_c_compiler_flag("-Werror=implicit-function-declaration" C_SUPPORTS_WERROR_IMPLICIT_FUNCTION_DECLARATION)
append_if(C_SUPPORTS_WERROR_IMPLICIT_FUNCTION_DECLARATION "-Werror=implicit-function-declaration" CMAKE_C_FLAGS)

# Warn on undefined macros. This is often an indication that an include to
# `mlir-config.h` or similar is missing.
check_c_compiler_flag("-Wundef" C_SUPPORTS_WUNDEF)
append_if(C_SUPPORTS_WUNDEF "-Wundef" CMAKE_C_FLAGS)
append_if(C_SUPPORTS_WUNDEF "-Wundef" CMAKE_CXX_FLAGS)

# Forbid mismatch between declaration and definition for class vs struct. This is
# harmless on Unix systems, but it'll be a ticking bomb for MSVC/Windows systems
# where it creeps into the ABI.
Expand Down
7 changes: 7 additions & 0 deletions mlir/include/mlir/Config/mlir-config.h.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@

/* This file enumerates variables from the MLIR configuration so that they
can be in exported headers and won't override package specific directives.
Defining the variables here is preferable over specifying them in CMake files
via `target_compile_definitions` because it is easier to ensure that they are
defined consistently across all targets: They are guaranteed to be 0/1
variables thanks to #cmakedefine01, so we can test with `#if` and find
missing definitions or includes with `-Wundef`. With `#ifdef`, these mistakes
can go unnoticed.

This is a C header that can be included in the mlir-c headers. */

#ifndef MLIR_CONFIG_H
Expand Down