-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[LangRef] Add aligned attribute description into masked.compress/expandload sections. #83808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ndload sections. align attribute is used for masked.compress/expandload in commit llvm#83519, llvm#83763, llvm#83516.
@llvm/pr-subscribers-llvm-ir Author: Yeting Kuo (yetingk) ChangesAlign attribute has already been used for masked.compress/expandload in commit #83519, #83763 and #83516. Full diff: https://github.com/llvm/llvm-project/pull/83808.diff 1 Files Affected:
diff --git a/llvm/docs/LangRef.rst b/llvm/docs/LangRef.rst
index f56d4ed28f2855..a2d1f816665250 100644
--- a/llvm/docs/LangRef.rst
+++ b/llvm/docs/LangRef.rst
@@ -24276,6 +24276,9 @@ Arguments:
The first operand is the base pointer for the load. It has the same underlying type as the element of the returned vector. The second operand, mask, is a vector of boolean values with the same number of elements as the return type. The third is a pass-through value that is used to fill the masked-off lanes of the result. The return type and the type of the '``passthru``' operand have the same vector type.
+The :ref:`align <attr_align>` parameter attribute can be provided for the first
+operand.
+
Semantics:
""""""""""
@@ -24333,6 +24336,8 @@ Arguments:
The first operand is the input vector, from which elements are collected and written to memory. The second operand is the base pointer for the store, it has the same underlying type as the element of the input vector operand. The third operand is the mask, a vector of boolean values. The mask and the input vector must have the same number of vector elements.
+The :ref:`align <attr_align>` parameter attribute can be provided for the second
+operand.
Semantics:
""""""""""
|
llvm/docs/LangRef.rst
Outdated
@@ -24276,6 +24276,9 @@ Arguments: | |||
|
|||
The first operand is the base pointer for the load. It has the same underlying type as the element of the returned vector. The second operand, mask, is a vector of boolean values with the same number of elements as the return type. The third is a pass-through value that is used to fill the masked-off lanes of the result. The return type and the type of the '``passthru``' operand have the same vector type. | |||
|
|||
The :ref:`align <attr_align>` parameter attribute can be provided for the first | |||
operand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention default of 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
llvm/docs/LangRef.rst
Outdated
@@ -24276,6 +24276,9 @@ Arguments: | |||
|
|||
The first operand is the base pointer for the load. It has the same underlying type as the element of the returned vector. The second operand, mask, is a vector of boolean values with the same number of elements as the return type. The third is a pass-through value that is used to fill the masked-off lanes of the result. The return type and the type of the '``passthru``' operand have the same vector type. | |||
|
|||
The :ref:`align <attr_align>` parameter attribute can be provided for the first | |||
operand. The pointer alignment is default to 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"is default to 1" -> "defaults to 1"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Sorry for my bad English.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Align attribute has already been used for masked.compress/expandload in commit #83519, #83763 and #83516.