[BOLT] Emit intra-function control flow in YAMLBAT #76911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
aaupov
added a commit
that referenced
this pull request
Mar 21, 2024
Relax assumptions that YAML output is not supported in BAT mode. Set up basic infrastructure for emitting YAML for functions not covered by BAT, such as from `.bolt.org.text` section (code identical to input binary sans external refs), or non-rewritten functions in non-relocation mode (where the function stays in the same section but BAT mapping is not emitted). This diff only produces YAML profile for non-BAT functions (skipped, non-simple). YAML profile for BAT functions is added in follow-up diffs: - #76911 emits YAML profile with internal control flow information only (branch profile), - #76896 adds cross-function profile (calls profile). Test Plan: Added bolt/test/X86/bolt-address-translation-yaml.test Reviewers: ayermolo, dcci, maksfb, rafaelauler Reviewed By: rafaelauler Pull Request: #76910
Created using spr 1.3.4 [skip ci]
aaupov
requested review from
maksfb,
rafaelauler,
ayermolo and
dcci
as code owners
rafaelauler
reviewed
Mar 22, 2024
| using BBHashMap = std::map<uint32_t, std::pair<unsigned, size_t>>; | ||
| /// Return a mapping from basic block input offset to hash and block index for a given function. | ||
| const BBHashMap &getBBHashMap(uint64_t OutputAddress) const { | ||
| return FuncHashes.at(OutputAddress).second; |
There was a problem hiding this comment.
I realized you used "at" a number of times now in this stack of diffs. Isn't this supposed to throw exceptions? Isn't LLVM codebase exception free?
There was a problem hiding this comment.
Thanks for pointing out. You're right, it does throw an exception: https://en.cppreference.com/w/cpp/container/map/at
I had code with find and assert but switched to at for conciseness. Let me unwind that.
There was a problem hiding this comment.
Addressed in #86353. Will rebase this and follow-up diffs shortly.
chencha3
pushed a commit
to chencha3/llvm-project
that referenced
this pull request
Mar 23, 2024
Relax assumptions that YAML output is not supported in BAT mode. Set up basic infrastructure for emitting YAML for functions not covered by BAT, such as from `.bolt.org.text` section (code identical to input binary sans external refs), or non-rewritten functions in non-relocation mode (where the function stays in the same section but BAT mapping is not emitted). This diff only produces YAML profile for non-BAT functions (skipped, non-simple). YAML profile for BAT functions is added in follow-up diffs: - llvm#76911 emits YAML profile with internal control flow information only (branch profile), - llvm#76896 adds cross-function profile (calls profile). Test Plan: Added bolt/test/X86/bolt-address-translation-yaml.test Reviewers: ayermolo, dcci, maksfb, rafaelauler Reviewed By: rafaelauler Pull Request: llvm#76910
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
aaupov
changed the base branch from
users/aaupov/spr/main.bolt-emit-intra-function-control-flow-in-yamlbat
to
main
aaupov
deleted the
users/aaupov/spr/bolt-emit-intra-function-control-flow-in-yamlbat
branch
aaupov
added a commit
that referenced
this pull request
Mar 25, 2024
Provide secondary entry points for `EntryDiscriminator` call info field in YAML profile. Increases BAT section size to: - large binary: 39655300 bytes (1.03x the original), - medium binary: 3834328 bytes (0.65x), - small binary: 924 bytes (0.64x). Depends on: #76911 Test Plan: - Updated bolt-address-translation{,-yaml}.test - Added openssl test: rafaelauler/bolt-tests#30 Reviewers: dcci, rafaelauler, maksfb, ayermolo Reviewed By: rafaelauler Pull Request: #86218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attach branch counters to YAML profile, covering intra-function control
flow.
Depends on: #86353
Test Plan: Updated bolt/test/X86/bolt-address-translation-yaml.test