Skip to content

Reland [OpenMP][Fix] libomptarget Fortran tests #76189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

fabianmcg
Copy link
Contributor

This patch fixes the erroneous multiple-target requirement in Fortran offloading tests. Additionally, it adds two new variables (test_flags_clang, test_flags_flang) to lit.cfg so that compiler-specific flags for Clang and Flang can be specified.

This patch re-lands: #74543. The error was caused by having:

config.substitutions.append(("%flags", config.test_flags))
config.substitutions.append(("%flags_clang", config.test_flags_clang))
config.substitutions.append(("%flags_flang", config.test_flags_flang))

when instead it has to be:

config.substitutions.append(("%flags_clang", config.test_flags_clang))
config.substitutions.append(("%flags_flang", config.test_flags_flang))
config.substitutions.append(("%flags", config.test_flags))

because LIT replaces with the first longest sub-string match.

This patch fixes the erroneous multiple-target requirement in Fortran offloading
tests. Additionally, it adds two new variables (test_flags_clang, test_flags_flang)
to lit.cfg so that compiler-specific flags for Clang and Flang can be specified.
@llvmbot llvmbot added the openmp:libomptarget OpenMP offload runtime label Dec 21, 2023
@jdoerfert jdoerfert merged commit 12250c4 into llvm:main Dec 21, 2023
@fabianmcg fabianmcg deleted the libomptarget_fix branch December 21, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomptarget OpenMP offload runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants