-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[AArch64][PAC] Expand blend(reg, imm) operation in aarch64-pauth pass #74729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# RUN: llc -mtriple=aarch64--- -run-pass=aarch64-ptrauth -verify-machineinstrs %s -o - | FileCheck %s | ||
|
||
# Test the corner cases that cannot be reliably tested using LLVM IR as input. | ||
|
||
--- | | ||
define i64 @blend_untied(i64 %unused, i64 %ptr_arg) { | ||
ret i64 0 | ||
} | ||
... | ||
--- | ||
# Check that the input register is copied to the output one, if not tied. | ||
|
||
name: blend_untied | ||
tracksRegLiveness: true | ||
body: | | ||
bb.0: | ||
liveins: $lr, $x0, $x1 | ||
$x0 = PAUTH_BLEND $x1, 42 | ||
RET undef $lr | ||
|
||
# CHECK: liveins: $lr, $x0, $x1 | ||
# CHECK-NEXT: {{^ +$}} | ||
# CHECK-NEXT: $x0 = ORRXrs $xzr, $x1, 0 | ||
# CHECK-NEXT: $x0 = MOVKXi $x0, 42, 48 | ||
# CHECK-NEXT: RET undef $lr | ||
|
||
... |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the one obvious regression test for the blend intrinsic, in "ptrauth-intrinsic-blend.ll", I seems to me that the case
Result != AddrDisc
isn't covered there, so the then part here isn't covered by a test case.If my impression is correct, maybe it would make sense to add a test to that file to cover this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a MIR-based test file, thank you.