[llvm][IR] Remove method IRBuilderBase::getInt8PtrTy

[JOE1994]

Users should migrate to IRBuilderBase::getPtrTy.

[llvmbot]

@llvm/pr-subscribers-llvm-ir

Author: Youngsuk Kim (JOE1994)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/74096.diff

1 Files Affected:

• (modified) llvm/include/llvm/IR/IRBuilder.h (+1)

diff --git a/llvm/include/llvm/IR/IRBuilder.h b/llvm/include/llvm/IR/IRBuilder.h
index 2cd9a665e9e5d05..f68dfc37ce9f01c 100644
--- a/llvm/include/llvm/IR/IRBuilder.h
+++ b/llvm/include/llvm/IR/IRBuilder.h
@@ -565,6 +565,7 @@ class IRBuilderBase {
   }
 
   /// Fetch the type representing a pointer to an 8-bit integer value.
+  [[deprecated("Pointers no longer have element types. Use getPtrTy instead.")]]
   PointerType *getInt8PtrTy(unsigned AddrSpace = 0) {
     return getPtrTy(AddrSpace);
   }

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[nikic]

I think you can go ahead and remove the method directly.

[JOE1994]

I think you can go ahead and remove the method directly.

Thank you. I pushed a follow-up commit that removes the method.

Is the IRBuilderBase::getInt8PtrTy method not exposed externally to clients?
Which methods can we delete without having to deprecate it first?

[aeubanks]

it is exposed, but the C++ API is unstable.

I edited the commit message to mention what people should migrate to