Skip to content

[X86] Add detection for more Tremont models #67150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

libenc
Copy link
Contributor

@libenc libenc commented Sep 22, 2023

Fix the issue that only the server series Tremont processors (Snow Ridge & Elkhart Lake) can be detected as Tremont, while the client series (Jasper Lake & Lakefield) will be guessed as Goldmont.

Noted that Lakefield is missing some features compare to other Tremont processors, but those features are also missing on FeatureTremont, which shouldn't be a problem. Those features are waitpkg, movdiri and movdir64b.

Copy link
Contributor

@FreddyLeaf FreddyLeaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@libenc
Copy link
Contributor Author

libenc commented Sep 25, 2023

Update: Add Snow Ridge

@libenc
Copy link
Contributor Author

libenc commented Sep 26, 2023

@FreddyLeaf Thank you for your review! And I forgot to mention that I have no commit access, could you please help with the merge?

There's also the newly added Snow Ridge changes that may need to be reviewed just in case.

@FreddyLeaf
Copy link
Contributor

Sorry, I just found https://github.com/torvalds/linux/blob/master/arch/x86/include/asm/intel-family.h shows below, which is conflict with here:

0x96 /* Elkhart Lake */

Do you have machines to confirm?

Fix the issue that only some server series Tremont processors
(Snow Ridge & Parker Ridge) can be detected as Tremont, while Elkhart Lake
and the client series (Jasper Lake & Lakefield) will be guessed
as Goldmont.
@libenc
Copy link
Contributor Author

libenc commented Sep 26, 2023

I can confirm that you're right, 0x96 should be Elkhart Lake.

The mistake has been corrected and I apologize for the inconvenience.

@FreddyLeaf
Copy link
Contributor

Thanks for confirming!

@FreddyLeaf FreddyLeaf merged commit e972bdb into llvm:main Sep 26, 2023
@libenc libenc deleted the add_tremont_models branch September 29, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants