[mlir][Interfaces][NFC] DestinationStyleOpInterface: Improve documentation #65927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mention that sizes of dynamic dims of tied OpResults/operands match at runtime.
|
@llvm/pr-subscribers-mlir ChangesMention that sizes of dynamic dims of tied OpResults/operands match at runtime.Full diff: https://github.com/llvm/llvm-project/pull/65927.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Interfaces/DestinationStyleOpInterface.td b/mlir/include/mlir/Interfaces/DestinationStyleOpInterface.td
index ff2da985c53d7c4..8558e0279e3e5bb 100644
--- a/mlir/include/mlir/Interfaces/DestinationStyleOpInterface.td
+++ b/mlir/include/mlir/Interfaces/DestinationStyleOpInterface.td
@@ -29,7 +29,8 @@ def DestinationStyleOpInterface : OpInterface<"DestinationStyleOpInterface"> {
ranked tensors and every tensor init is tied to a corresponding tensor
OpResult in a 1-to-1 fashion. The i-th init tensor is tied to the i-th
OpResult. The op may not have any additional OpResults. Init operands and
- their tied OpResults have the same type.
+ their tied OpResults have the same type. Dynamic dimension sizes also match
+ at runtime.
If the op has "buffer semantics", then the input operands are either ranked
memrefs or other non-tensor/memref types ("scalar" types). Furthermore, the
|
matthias-springer
changed the title
kaitingwang
approved these changes
Sep 11, 2023
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
…ation (llvm#65927) Mention that sizes of dynamic dims of tied OpResults/operands match at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mention that sizes of dynamic dims of tied OpResults/operands match at runtime.