[OpenMP][test][VE] Change to use VE_LD_LIBRARY_PATH for VE

[kaz7]

Change to use VE_LD_LIBRARY_PATH for VE instead of LD_LIBRARY_PATH. The VE is connected to the host, and compiled test programs for VE is invoked on the host and transferred to the VE. If programs are compiled for the host, we use LD_LIBRARY_PATH. Otherwise, we use VE_LD_LIBRARY_PATH.

[llvmbot]

@llvm/pr-subscribers-openmp

Changes

Change to use VE_LD_LIBRARY_PATH for VE instead of LD_LIBRARY_PATH. The VE is connected to the host, and compiled test programs for VE is invoked on the host and transferred to the VE. If programs are compiled for the host, we use LD_LIBRARY_PATH. Otherwise, we use VE_LD_LIBRARY_PATH.

Full diff: https://github.com/llvm/llvm-project/pull/65869.diff

1 Files Affected:

• (modified) openmp/runtime/test/lit.cfg (+4)

diff --git a/openmp/runtime/test/lit.cfg b/openmp/runtime/test/lit.cfg
index ab69819530d4a0..650d3853e85111 100644
--- a/openmp/runtime/test/lit.cfg
+++ b/openmp/runtime/test/lit.cfg
@@ -12,12 +12,16 @@ if 'PYLINT_IMPORT' in os.environ:
     lit_config = object()
 
 def prepend_dynamic_library_path(path):
+    target_arch = getattr(config, 'target_arch', None)
     if config.operating_system == 'Windows':
         name = 'PATH'
         sep = ';'
     elif config.operating_system == 'Darwin':
         name = 'DYLD_LIBRARY_PATH'
         sep = ':'
+    elif target_arch == 've':
+        name = 'VE_LD_LIBRARY_PATH'
+        sep = ':'
     else:
         name = 'LD_LIBRARY_PATH'
         sep = ':'

[jhuber6]

Didn't we delete the ve target because it was unmaintained? There was no one available to port it to the new interface so we deleted it for the 17 release.

[shiltian]

Didn't we delete the ve target because it was unmaintained? There was no one available to port it to the new interface so we deleted it for the 17 release.

I think this is for libomp.

[jhuber6]

Didn't we delete the ve target because it was unmaintained? There was no one available to port it to the new interface so we deleted it for the 17 release.

I think this is for libomp.

You are correct, sorry about that.

[shiltian]

So the host side libraries will not be used at all?

[kaz7]

So the host side libraries will not be used at all?

No for libomp runtime. All test programs uses only the VE side libraries. But, some compiler tools running on the host uses libcxx and other host side libraries, though.

[kaz7]

And thank you for the quick correction.

[shiltian]

LGTM. I don't think many people, including me, can run on VE in the community, so I suppose it can work. :-)

[jhuber6]

Thanks

LGTM. I don't think many people, including me, can run on VE in the community, so I suppose it can work. :-)

It would be nice if there was a buildbot or machine that other people could test it on. That's the main reason we dropped the offloading support, no one knew if it actually worked.

[kaz7]

Thank you. We will add check-openmp to our buildbot, https://lab.llvm.org/buildbot/#/builders/91, after fixing few more problems.