[NFC] fix failed ompt tests on M1 device #65696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiltian
reviewed
Sep 7, 2023
openmp/runtime/test/ompt/callback.h
Outdated
| @@ -190,8 +190,8 @@ ompt_label_##id: | |||
| // On AArch64 the NOP instruction is 4 bytes long, can be followed by inserted | |||
| // store instruction (another 4 bytes long). | |||
| #define print_possible_return_addresses(addr) \ | |||
| printf("%" PRIu64 ": current_address=%p or %p\n", ompt_get_thread_data()->value, \ | |||
| ((char *)addr) - 4, ((char *)addr) - 8) | |||
| printf("%" PRIu64 ": current_address=%p or %p or %p\n", ompt_get_thread_data()->value, \ | |||
There was a problem hiding this comment.
We probably want to limit this to macos only, so it might be a good idea to guard it with proper macros.
lixi-zhou
force-pushed
the
fix-ompt-test-on-m1
branch
from
c671472 to
eacec22
Compare
lixi-zhou
force-pushed
the
fix-ompt-test-on-m1
branch
from
e6e7276 to
2eb767c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the 2 failed ompt tests on M1 device found on #63194.
For the details of this fix, please check the origin discussion in #63194 (comment)
Thanks @jprotze for the fix.