[libc][NFC] Cleanup the GPU file I/O utility header #65680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivachandra
approved these changes
Sep 8, 2023
libc/src/stdio/gpu/file.h
Outdated
| port.close(); | ||
| return ret; | ||
| } | ||
| if constexpr (opcode == RPC_WRITE_TO_STREAM) |
There was a problem hiding this comment.
It a multi-line statement under the if so you should use braces. I was struggling to figure out alignment of the indents.
Summary: The GPU uses separate implementations to perform file IO. This is all done through the RPC interface and we kept it minimal such that we could treat a `stdin`, `stdout`, or `stderr` handle from the CPU correctly on the GPU. The RPC implementation uses different opcodes for whether or not we are using one of the standard streams. This is so we do not need to initialize anything to access the CPU's standard stream, because the server knows that it should print to `stdout` if it gets the `STDOUT` variant of the opcode. It also saves us an RPC call, which are expensive relatively speaking. This patch simply cleans up this interface to make them all use a common function. This is done in preparation to implement some more file IO functions like getc or putc.
jhuber6
force-pushed
the
CleanupRPCFile
branch
from
d8db227 to
be51e51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The GPU uses separate implementations to perform file IO. This is all
done through the RPC interface and we kept it minimal such that we could
treat a
stdin,stdout, orstderrhandle from the CPU correctly onthe GPU. The RPC implementation uses different opcodes for whether or
not we are using one of the standard streams. This is so we do not need
to initialize anything to access the CPU's standard stream, because the
server knows that it should print to
stdoutif it gets theSTDOUTvariant of the opcode. It also saves us an RPC call, which are expensive
relatively speaking. This patch simply cleans up this interface to make
them all use a common function. This is done in preparation to implement
some more file IO functions like getc or putc.