[mlir][tensor] Check the EmptyOp's dynamicSize to be non-negative #65577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joker-eph
reviewed
Sep 7, 2023
| @@ -621,6 +621,18 @@ LogicalResult EmptyOp::verify() { | |||
| return emitOpError("incorrect number of dynamic sizes, has ") | |||
| << getDynamicSizes().size() << ", expected " | |||
| << getType().getNumDynamicDims(); | |||
|
|
|||
| if (getDynamicSizes().size() > 0) { | |||
There was a problem hiding this comment.
This check does not seem needed?
| if (getDynamicSizes().size() > 0) { | ||
| if (llvm::any_of(getDynamicSizes(), [](Value operand) { | ||
| APInt constSizeArg; | ||
| if (!matchPattern(operand, m_ConstantInt(&constSizeArg))) { |
There was a problem hiding this comment.
This does not belong to the verifier, because: https://mlir.llvm.org/getting_started/DeveloperGuide/#ir-verifier
There was a problem hiding this comment.
Thank you for teaching me about IR's verifier.
This is why the guidelines to write verifier is to stick to information local to an operation (think “what I see when I print this operation alone”). Looking through operands or results is extremely unusual and should be avoided.
I understand it, so i will remove this checker from verifier.
| @@ -691,6 +703,9 @@ struct ReplaceEmptyTensorStaticShapeDims : OpRewritePattern<EmptyOp> { | |||
| Value dynamicSize = op.getDynamicSizes()[ctr++]; | |||
| std::optional<int64_t> cst = getConstantIntValue(dynamicSize); | |||
| if (cst.has_value()) { | |||
| // dynamic size must be non-negative. | |||
| if (cst.value() < 0) | |||
| return failure(); | |||
There was a problem hiding this comment.
This should be enough without the verifier right?
joker-eph
approved these changes
Sep 8, 2023
|
@joker-eph Could you merge it? |
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
…vm#65577) This patch addresses a crash that occurs when negative dynamic sizes are provided in tensor.emptyOp by adding a check to ensure that dynamic sizes are non-negative. Fixes llvm#64064
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses a crash that occurs when negative dynamic sizes are provided in tensor.emptyOp by adding a check to ensure that dynamic sizes are non-negative.
Fixes #64064