[lld/ELF,gold] Remove transitionary opaque pointer flags #65529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay to remove the option. Wasn't there some tests using it? |
|
Should also remove the equivalent here then: https://github.com/llvm/llvm-project/blob/main/llvm/tools/gold/gold-plugin.cpp#L311 |
This was only useful during the transition when mixing non-opaque-pointer and opaque-pointer IR, now everything uses opaque pointers.
I believe they were removed when the no-opaque-pointers versions of the flags were removed |
aeubanks
changed the title
done |
|
LGTM, thanks! |
|
this is my first PR review. I don't see any accept button I could press, is that expected? Just "Close with comment"... |
MaskRay
approved these changes
Sep 6, 2023
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
This was only useful during the transition when mixing non-opaque-pointer and opaque-pointer IR, now everything uses opaque pointers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was only useful during the transition when mixing non-opaque-pointer and opaque-pointer IR,
now everything uses opaque pointers.