Skip to content

[llvm-debuginfo-analyzer] Add --output-sort=none option #145761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions llvm/docs/CommandGuide/llvm-debuginfo-analyzer.rst
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,7 @@ output for a single compilation unit.

.. code-block:: text

=none: Unsorted output (i.e. as read from input).
=kind: Sort by element kind.
=line: Sort by element line number.
=name: Sort by element name.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,15 @@
; RUN: %p/Inputs/test-codeview-clang.o 2>&1 | \
; RUN: FileCheck --strict-whitespace -check-prefix=ONE %s

; If `--output-sort=none`, LVReader::sortScopes() has no effect and elements are
; iterated in the order in which they were added (which matches the increasing
; offset of the reference output).
; RUN: llvm-debuginfo-analyzer --attribute=level,format \
; RUN: --output-sort=none \
; RUN: --print=scopes,symbols,types,lines,instructions \
; RUN: %p/Inputs/test-codeview-clang.o 2>&1 | \
; RUN: FileCheck --strict-whitespace -check-prefix=ONE %s

; RUN: llvm-debuginfo-analyzer --attribute=level,format \
; RUN: --output-sort=offset \
; RUN: --print=elements \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,15 @@
; RUN: %p/Inputs/test-dwarf-clang.o 2>&1 | \
; RUN: FileCheck --strict-whitespace -check-prefix=ONE %s

; If `--output-sort=none`, LVReader::sortScopes() has no effect and elements are
; iterated in the order in which they were added (which matches the increasing
; offset of the reference output).
; RUN: llvm-debuginfo-analyzer --attribute=level,format \
; RUN: --output-sort=none \
; RUN: --print=scopes,symbols,types,lines,instructions \
; RUN: %p/Inputs/test-dwarf-clang.o 2>&1 | \
; RUN: FileCheck --strict-whitespace -check-prefix=ONE %s

; RUN: llvm-debuginfo-analyzer --attribute=level,format \
; RUN: --output-sort=offset \
; RUN: --print=elements \
Expand Down
1 change: 1 addition & 0 deletions llvm/test/tools/llvm-debuginfo-analyzer/cmdline.test
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ HELP-ALL: --output-file=<filename> - Redirect output to the specified file.
HELP-ALL: --output-folder=<pathname> - Folder name for view splitting.
HELP-ALL: --output-level=<N> - Only print to a depth of N elements.
HELP-ALL: --output-sort=<value> - Primary key when ordering logical view (default: line).
HELP-ALL: =none - Unsorted output (i.e. as read from input).
HELP-ALL: =kind - Sort by element kind.
HELP-ALL: =line - Sort by element line number.
HELP-ALL: =name - Sort by element name.
Expand Down
4 changes: 3 additions & 1 deletion llvm/tools/llvm-debuginfo-analyzer/Options.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,9 @@ static cl::opt<LVSortMode, true> OutputSort(
"output-sort", cl::cat(OutputCategory),
cl::desc("Primary key when ordering logical view (default: line)."),
cl::Hidden, cl::ZeroOrMore,
values(clEnumValN(LVSortMode::Kind, "kind", "Sort by element kind."),
values(clEnumValN(LVSortMode::None, "none",
"Unsorted output (i.e. as read from input)."),
clEnumValN(LVSortMode::Kind, "kind", "Sort by element kind."),
clEnumValN(LVSortMode::Line, "line", "Sort by element line number."),
clEnumValN(LVSortMode::Name, "name", "Sort by element name."),
clEnumValN(LVSortMode::Offset, "offset", "Sort by element offset.")),
Expand Down